Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest schnorrkel version (align with Substrate) #398

Open
jacogr opened this issue Jul 9, 2022 · 1 comment
Open

Update to latest schnorrkel version (align with Substrate) #398

jacogr opened this issue Jul 9, 2022 · 1 comment
Labels
P2 - Medium Important but not urgent. Enhances functionality and value, scheduled after higher priorities.

Comments

@jacogr
Copy link
Member

jacogr commented Jul 9, 2022

After #397

One small issue would be that the newest (if we update to that as well) uses curve25519-dalek-ng while ed25519-zebra as linked above above still uses curve25519-dalek - having different versions for the same functionality does add overhead/size to the WASM. Either way try to align versions to use the same deps to not have an explosion.

We could possibly also test a trick like this - https://github.com/w3f/schnorrkel/blob/93e27d28f6a112be429295af7fd4549dde9f6796/Cargo.toml#L32

@jacogr
Copy link
Member Author

jacogr commented Mar 13, 2023

Just keep to curve25519-dalek-ng as per the default sr25519 - which also means that the ed25519 dep needs to change. (We certainly only want 1 of these)

@TarikGul TarikGul added the P2 - Medium Important but not urgent. Enhances functionality and value, scheduled after higher priorities. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 - Medium Important but not urgent. Enhances functionality and value, scheduled after higher priorities.
Projects
Development

No branches or pull requests

2 participants