feat: ledger support #200
Merged
feat: ledger support #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lucasgabrielgsp
commented
Oct 6, 2023
lucasgabrielgsp
commented
- implement ledger support
lucaslovato
reviewed
Oct 10, 2023
| @@ -923,6 +959,86 @@ export class KeyringManager implements IKeyringManager { | |||
| return trezorAccount; | |||
| } | |||
|
|
|||
| private async _createLedgerAccount( | |||
There was a problem hiding this comment.
Suggested change
| private async _createLedgerAccount( | |
| private async createLedgerAccount( |
lucaslovato
reviewed
Oct 10, 2023
| index: +index, | ||
| slip44, | ||
| }); | ||
| const accountAlreadyExists = |
There was a problem hiding this comment.
I suggest that each part of this can be one const and accountAlreadyExists is the or of those consts. This way is really hard to read this variable
lucaslovato
reviewed
Oct 10, 2023
| ); | ||
|
|
||
| const id = | ||
| Object.values(accounts[KeyringAccountType.Ledger]).length < 1 |
There was a problem hiding this comment.
If you create a const for this in line 991 you can reuse it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.