Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI version 0.10.4 and 0.10.5 produce wasm-bindgen TypeScript artifacts when building Rust Wasm wrap #1794

Open
2 tasks done
krisbitney opened this issue Jun 28, 2023 · 1 comment
Labels
type: bug Something isn't working

Comments

@krisbitney
Copy link
Contributor

krisbitney commented Jun 28, 2023

Describe the bug
CLI versions 0.10.4 and 0.10.5 produce wasm-bindgen TypeScript artifacts when building Rust Wasm wrap. Clearing the docker cache does not fix the issue. The wrappers are still working and can be invoked.

TODO:

  • check if it happens with 0.10.4
  • clear docker cache with docker system prune --all --volumes

Please provide the steps to reproduce and if possible a minimal demo of the problem.

  1. Clone https://github.com/polywrap/wrap-abi-bindgen.git
  2. Checkout branch kris/wrap-0.1
  3. navigate to the implementations/app-typescript directory
  4. In package.json, change the polywrap and @polywrap/schema-parse dependency versions to 0.10.5
  5. run nvm use && yarn && yarn build
  6. The unexpected artifacts can be found in the build folder

Expected behavior
All wasm-bindgen should be removed by wasm-snip

Screenshots / logs
Screenshot 2023-06-28 at 10 48 21 AM
Screenshot 2023-06-28 at 10 49 43 AM
Screenshot 2023-06-28 at 10 49 52 AM
Screenshot 2023-06-28 at 10 49 59 AM
Screenshot 2023-06-28 at 10 50 06 AM

The wrap's Rust dependencies:

[dependencies]
polywrap-wasm-rs = { version = "~0.10.5" }
serde = { version = "1.0", features = ["derive"] }
serde_json = { version = "1.0.97" }
handlebars = { version = "4.3.7" }
lazy_static = { version = "1.4.0" }
regex = { version = "1.8.4" }

Relevant environment details:

  • OS: Mac OS

Additional context
I am aware that this also occurred when building the ethers-utils wrap found here: https://github.com/polywrap/ethers/tree/main/wraps/utils

@krisbitney krisbitney added the type: bug Something isn't working label Jun 28, 2023
@krisbitney krisbitney changed the title CLI version 0.10.5 produces wasm-bindgen TypeScript artifacts when building Rust Wasm wrap CLI version 0.10.4 and 0.10.5 produce wasm-bindgen TypeScript artifacts when building Rust Wasm wrap Jun 28, 2023
@pileks
Copy link
Contributor

pileks commented Jun 29, 2023

Can confirm that this same thing happens on Ubuntu 20.04.4 LTS, running through WSL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants