-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
current F-P inferences gaf #659
Comments
Once we have established if we are getting the file from the correct place, can we check if we still see this drop in numbers? This was the original issue. @mah11 |
We're getting it from here: I don't know if it's the right one. I'm very confused by it all. That file is updated daily which I guess is a good sign. |
So I don't think we are getting the inferred gaf from the above location. http://build.berkeleybop.org/view/GAF/job/gaf-check-pombase/gene_association.pombase.inf.gaf we don't get these annotations: but we do get this one: PomBase SPCC737.09c hmt1 GO:0071994 PMID:7876244 IMP P vacuolar phytochelatin transmembrane transporter Hmt1 SPCC74.08c protein taxon:4896 20120531 GOC odd? |
The one I pointed to is also updated. I don't know what the difference is between these 2 files. So we will work on the assumption that the one you are using is the correct one. Midori does this file still show reduced numbers? I will do some spot checks on this one. |
OK both of these files are the same. |
I will list any problems I find with the file here. I don't thhink this file is built from current data. It contains this annotation: PomBase SPCC74.06 mak3 GO:0034599 PMID:20919928 IC GO:0032874 P this must be generated from an MF IC annotation, but as far as I can see pombe mak3 does not have any IC annotation ( I checked in artemis to be sure that it is not filtered, I also checked amigo to be sure it isn't a submission timing issue) |
Does anyone understand this row: PomBase SPBC2F12.13 klp5 GO:1990758 PMID:21664573 IC GO:0005515 F kinesin-8 family plus-end microtubule motor Klp5 sot1 protein taxon:4896 20161018 GOC-OWL part_of(GO:1990758) |
also see geneontology/go-site#524. it's a ghastly mess. |
I'm confused again. Is this the right file?: In geneontology/go-site#524 (comment) you mention a new location. I thought the URL we're using is the new location. Is there a new new location? |
I've read the GO issue more carefully now. Is this the new new location?: I compared that file with the one we're using. They are very similar except that column 9 ("Aspect") is different. That's alarming. Although it shouldn't cause problems for PomBase as we ignore that column. Here's an example: gene_association.pombase.inf.gaf:
pombase-prediction.gaf:
The only other different between the two files is that gene_association.pombase.inf.gaf has one extra annotation:
|
Don't worry yet, if we don't include the file I don't think we will lose so much. I'll check the file contents when I get the go ahead. There appears to still be a problem. |
Yes, this is the new new location, and what GO is now billing as the correct one. The billing is still fairly subtle, and Tanya-at-TAIR has asked them to make an announcement when they've got the bugs fixed. Oh yeah, as your snippet shows, they haven't fixed all the bugs yet, so as Val says, no rush. |
@kimrutherford are we loading any of the process-from function prediction gafs? because I see some in here: SPAC21E11.06.1 GO:0065009 regulation of molecular function GOC it's not a big deal, because they will be subject to our normal filtering I was just wondering where we get them from (probably from the GOA file?) |
I see it in goa so I think that's it. can you confirm. |
I haven't changed the loader to use the new location yet: But the two files are nearly identical. The annotations you list in your comment are in gene_association.pombase.inf.gaf |
Yep the new file looks much better now, but we'll wait to switch. I'd still like to see better redundancy filtering (because it is difficult for us to discard experimental annotations, even when less specific than ours from the same source), but we get |
I've changed the load script to get the inferred GAF file from the new location: http://snapshot.geneontology.org/products/annotations/pombase-prediction.gaf |
Ok when the issues are solved with the "occurs in" we can reassess whether to import the component annotations too. phew... (I'll check tomorrow though anyway) |
Can this be closed now? |
I think so.... |
where are we getting this file from currently?
here?
http://build.berkeleybop.org/view/GAF/job/gaf-check-pombase/gene_association.pombase.inf.gaf
https://curation.pombase.org/pombe/stats/annotation
The text was updated successfully, but these errors were encountered: