Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search box in the gene page sequence section #2266

Open
kimrutherford opened this issue Oct 30, 2024 · 9 comments
Open

Add a search box in the gene page sequence section #2266

kimrutherford opened this issue Oct 30, 2024 · 9 comments
Assignees
Labels

Comments

@kimrutherford
Copy link
Member

It would be very useful to be able to type eg. 100..120 into a field and then have those residues selected.

@kimrutherford
Copy link
Member Author

I started implementing this but this realised that it's trickier than I thought. :-)

It's especially tricky when showing the nucleotide sequence because the exons, introns and bases upstream all change the residue positions. We might have to just ignore the nucleotide sequence mode initially.

I've put what I've done so far on a branch and I'll come back to it later:
https://github.com/pombase/website/tree/issue-2266-sequence-search-box

@ValWood
Copy link
Member

ValWood commented Oct 30, 2024

could just implement for proteins - I never look at DNA nt ;)

@kimrutherford
Copy link
Member Author

could just implement for proteins

OK, I've done that. It's on my desktop if you'd like to test it. Press return after typing the range.
https://desktop.kmr.nz/gene/SPAC8F11.08c

It will be on the dev site in 20-30 minutes from now. I won't add it to the main site yet as there are a few things to fix and tidy.

image

image

image

@ValWood
Copy link
Member

ValWood commented Oct 31, 2024

Niiiice

@kimrutherford
Copy link
Member Author

Could try this on Safari when you get a chance?

I'll try it on Windows.

Selection of text on screen is a bit platform specific so there could be differences or bugs. I found some differences in behaviour even between Firefox and Chrome on Linux.

@ValWood
Copy link
Member

ValWood commented Oct 31, 2024

seems fine on firefox

@PCarme
Copy link
Contributor

PCarme commented Nov 1, 2024

Could try this on Safari when you get a chance?

That works well on Safari

kimrutherford added a commit that referenced this issue Nov 3, 2024
@kimrutherford
Copy link
Member Author

Thank you both for testing.

I've now tried on Microsoft Edge on Windows and that works OK too.

@kimrutherford
Copy link
Member Author

I fixed the remaining issues that were annoying me and I've added a "Clear selection" button.

It's now available on the main site. Let me know if you see any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants