Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot identify methods correctly. #132

Closed
yiming-tang-cs opened this issue Jan 14, 2019 · 2 comments
Closed

Cannot identify methods correctly. #132

yiming-tang-cs opened this issue Jan 14, 2019 · 2 comments
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on

Comments

@yiming-tang-cs
Copy link
Contributor

Currently, I use file path and method signature to identify methods. Method signature works well, but file path doesn't.

The git historical methods cannot be bound Java model elements (resolving binding always returns null for a method declaration), so I could not get their typeFQNs.

How can we know a git historical method is an existing method in the current source code?

@yiming-tang-cs
Copy link
Contributor Author

Fixed file matching.

@khatchad
Copy link
Member

The git historical methods cannot be bound Java model elements (resolving binding always returns null for a method declaration), so I could not get their typeFQNs.

Of course not. That's why they are "historical." They are no longer in the project.

How can we know a git historical method is an existing method in the current source code?

This is the whole point of #98.

@khatchad khatchad added duplicate This issue or pull request already exists wontfix This will not be worked on labels Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants