Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to not lower logs with particular keywords in their messages #206

Closed
yiming-tang-cs opened this issue May 2, 2019 · 4 comments
Closed

Add setting to not lower logs with particular keywords in their messages #206

yiming-tang-cs opened this issue May 2, 2019 · 4 comments
Assignees
@yiming-tang-cs
Labels
enhancement New feature or request

Comments

@yiming-tang-cs
Copy link
Contributor

yiming-tang-cs commented May 2, 2019 •
edited
Loading

Per jenkinsci/jenkins#4007, there are some logs that shouldn't be lowered. Some of them have words like "failed" and "disabled". We could also add "error" to that list. The comparison should be case insensitive. This is a precursor to #207.

--Commented by @khatchad
@yiming-tang-cs yiming-tang-cs changed the title Add setting to not lower logs with particular keywords in their messages #204 Add setting to not lower logs with particular keywords in their messages May 2, 2019
@yiming-tang-cs
Copy link
Contributor Author

Do we need to count the number of log levels which are not transformed due to it?

@khatchad khatchad added the enhancement New feature or request label May 3, 2019
@khatchad
Copy link
Member

khatchad commented May 3, 2019

Also "exception."

yiming-tang-cs pushed a commit to yiming-tang-cs/Logging-Level-Evolution-Plugin that referenced this issue May 3, 2019
ponder-lab#206
4754c4f
@yiming-tang-cs yiming-tang-cs mentioned this issue May 3, 2019
Merged
khatchad added a commit that referenced this issue May 3, 2019
@khatchad
More keywords.
b7f0865 
For #206.
khatchad added a commit that referenced this issue May 3, 2019
@khatchad
Keywords.
17078c3 
#206
@khatchad
Copy link
Member

@saledouble Has this been completed?

@yiming-tang-cs
Copy link
Contributor Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yiming-tang-cs yiming-tang-cs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@khatchad @yiming-tang-cs