Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actions #41

Closed
khatchad opened this issue Jun 20, 2018 · 9 comments
Closed

Make actions #41

khatchad opened this issue Jun 20, 2018 · 9 comments
Assignees
Labels
enhancement New feature or request

Comments

@khatchad
Copy link
Member

khatchad commented Jun 20, 2018

Once you the (preliminary) mismatches, then take action. If there's no mismatch, no action needed, but you should record that in log_actions.csv as Action.NONE. If there's a mismatch, you need to fix the log level.

First, let's document it action an action. Then, we'll do the transformation later.

┆Issue is synchronized with this Asana task

@khatchad khatchad added the enhancement New feature or request label Jun 20, 2018
@khatchad khatchad added this to the Transformation milestone Jun 20, 2018
@khatchad khatchad added the enhancement New feature or request label Jun 22, 2018
@khatchad
Copy link
Member Author

Once you create the method mentioned in #40, you can proceed with this issue.

@khatchad
Copy link
Member Author

khatchad commented Jul 2, 2018

@saledouble Please upload an example CSV file.

@yiming-tang-cs
Copy link
Contributor

The file: https://drive.google.com/file/d/1a3vsOZbloO5ybWSkwQQ4uok6ME6jYQw_/view?usp=sharing

The file content:

subject raw log expression start pos logging level type FQN enclosing method action
Test Logger.getGlobal().log(Level.INFO,"hi") 161 INFO p.A m() CONVERT_TO_SEVERE
Test Logger.getGlobal().log(level,"hi") 117   p.A m() NONE
Test Logger.getGlobal().log(Level.WARNING,"hi") 235 WARNING p.A n() CONVERT_TO_FINEST

@khatchad
Copy link
Member Author

khatchad commented Jul 2, 2018

@saledouble Why is there an extra line at the top of the file?

@khatchad khatchad reopened this Jul 2, 2018
@khatchad
Copy link
Member Author

khatchad commented Jul 2, 2018

Otherwise, looks nice. Are you sure these suggestions look good?

@yiming-tang-cs
Copy link
Contributor

Why is there an extra line at the top of the file?

This line is not from the project. I cleared the previous content and might not delete this line. The local file does not contain this line. I generate a new file and it looks fine: https://drive.google.com/file/d/1TKzJy-MsWGw4XPaFBu6sjZpV7O1_gRZi/view?usp=sharing
Sorry about it.

@yiming-tang-cs
Copy link
Contributor

Are you sure these suggestions look good?

Actually, I am not sure, but this is what I could get for now.

@khatchad
Copy link
Member Author

khatchad commented Jul 3, 2018 via email

@yiming-tang-cs
Copy link
Contributor

Why are you unsure?

These suggestions for logging level are from DOI for enclosing methods which is one of the factors to influence the logging levels. I think we should consider more factors in the future.

In the previous discussion, the reason that we use DOI model is that logging level is also a reflection of the developer's interests. But I am thinking about whether the interests in DOI model and logging level are same. The interests in DOI model of our project shows frequency that the developers interact with the enclosing method, which the logging level shows the interests of message content. Hence, we may need to analyze the message content and improve our model.

@khatchad khatchad added the enhancement New feature or request label Jul 3, 2018
@khatchad khatchad added the enhancement New feature or request label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants