Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all logging statements #75

Open
khatchad opened this issue Jul 31, 2018 · 3 comments
Open

Collect all logging statements #75

khatchad opened this issue Jul 31, 2018 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@khatchad
Copy link
Member

khatchad commented Jul 31, 2018

Currently, we are getting the java element corresponding to the enclosing method declaration. Are we also handling field initializers and/or initializer blocks and/or constructors?

┆Issue is synchronized with this Asana task

@yiming-tang-cs
Copy link
Contributor

yiming-tang-cs commented Aug 1, 2018

We do not handle field initializers or initializer blocks, but we handle constructors.

@khatchad khatchad changed the title Are we collecting all logging statements? Collecting all logging statements Aug 3, 2018
@khatchad khatchad added the bug Something isn't working label Aug 3, 2018
@khatchad
Copy link
Member Author

khatchad commented Aug 3, 2018

I guess field initializers wouldn't make sense since they are void methods. But, don't you have a visitor that visits every method invocation? It should pick up ones in static initializers no?

@khatchad khatchad added this to the Future milestone Sep 5, 2018
@khatchad
Copy link
Member Author

khatchad commented Sep 5, 2018

➤ Raffi Khatchadourian commented:

We can move this into the future but it needs to be done at some point prior to experiments.

@ponder-sync ponder-sync added the bug Something isn't working label Sep 13, 2018
@khatchad khatchad changed the title Collecting all logging statements Collect all logging statements Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants