Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick one way to extract method changes #95

Closed
yiming-tang-cs opened this issue Oct 18, 2018 · 4 comments
Closed

Pick one way to extract method changes #95

yiming-tang-cs opened this issue Oct 18, 2018 · 4 comments

Comments

@yiming-tang-cs
Copy link
Contributor

yiming-tang-cs commented Oct 18, 2018

image


  1. Using AST differences. Once we get the AST differences, we increase the DOI of the method.
    Pros.
    We only need to consider the code changes instead of the non-code changes.
    We do not care about the ordering of the methods in the class.
    Cons.
    It's exspensive to implement and use, espeacially for a large project.
    No matter how many lines of code changes in a method, the DOI value is only modified once.

  1. Using line differences. For each line deleted or added, the DOI value of the method which includes that line is modified.
    Pros.
    Easier to implement.
    It's effective.
    Like mylyn plugin, it also considers the non code changes, such as whitespace.
    Cons.
    If the developers sort the methods, the DOI values could be modified a lot. Actually, sorting the methods should not change the DOI values of the methods.

┆Issue is synchronized with this Asana task

@yiming-tang-cs yiming-tang-cs changed the title Pick on way to extract method changes. Pick one way to extract method changes. Oct 18, 2018
@yiming-tang-cs
Copy link
Contributor Author

I am using line differences now. How can we process comments? The comments above the method should be considered as part of the method? Right?

@khatchad
Copy link
Member

Sorry, is this related to #39?

@yiming-tang-cs
Copy link
Contributor Author

Sorry, is this related to #39?

Yes.

@ponder-sync ponder-sync changed the title Pick one way to extract method changes. Pick one way to extract method changes Oct 31, 2018
@khatchad
Copy link
Member

We picked the second one and use edit differences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants