Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ponder doesn't run with React 19 #1568

Closed
Sam-Scolari opened this issue Feb 27, 2025 · 3 comments · Fixed by #1571
Closed

Ponder doesn't run with React 19 #1568

Sam-Scolari opened this issue Feb 27, 2025 · 3 comments · Fixed by #1571

Comments

@Sam-Scolari
Copy link

Version

0.9.24

Current behavior

In situations where Ponder needs to be ran in a project that requires React 19, ponder dev fails due to a dependency (Ink) that doesn't support the latest version of React.

The error message

var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner;

TypeError: Cannot read properties of undefined (reading 'ReactCurrentOwner')
    at $$$reconciler (C:\Users\samsc\Documents\GitHub\ponder-react-19\my-app\node_modules\react-reconciler\cjs\react-reconciler.development.js:491:46)  
    at file:///C:/Users/samsc/Documents/GitHub/ponder-react-19/my-app/node_modules/ink/build/reconciler.js:59:16

There is currently an open issue for this since December, but with little to no support from the maintainers of Ink.

Expected behavior

No response

Steps to reproduce

This repo can be used to reproduce the issue

Steps

  1. bun create ponder
  2. bun i react@19
  3. bun dev

Link to repository

https://github.com/Sam-Scolari/ponder-react-19

Anything else?

No response

@typedarray
Copy link
Collaborator

Thanks, really appreciate the repro.

It might be time to surgically extract Ink.

https://npmgraph.js.org/?q=ponder#zoom=w&select=exact%3Aink%404.4.1

@typedarray
Copy link
Collaborator

I just published prerelease 0.9.24-next.1 which removes the ink and react dependencies in favor of a custom terminal UI implementation.

Could you please

  1. Try this version with your environment to confirm that removing the react dep solves the problem
  2. Validate that the new terminal UI is working for you (ponder dev)

Thanks!

@Sam-Scolari
Copy link
Author

Just updated and tried this, ponder dev works now! Haven't deployed my indexer to production yet so ilyk if I have any issues with that, but it does seem to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants