Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ext. player/cast device subtitles for local files and Seedbox subtitles #2917

Open
kiriles90 opened this issue Mar 9, 2024 · 0 comments

Comments

@kiriles90
Copy link
Collaborator

kiriles90 commented Mar 9, 2024

Operating System Version:

All

Popcorn Time Version:

Latest build / development branch

Download date:

22-Mar-24

Expected Behaviour:

  1. When playing a local file, serve the subtitles found to the ext. player/cast device the same way it does for the native player.
  2. When starting playback from the Seedbox find and serve the subtitles

Actual Behaviour:

  1. Finds subtitles but doesn't serve them to the ext. player/cast device.
  2. And in the case of the Seedbox it doesn't find nor serve any subtitles.

Steps to reproduce the behaviour:

    1. Drag&drop a video file in the app that it can find subtitles for.
    2. See the difference between the native and ext. players. (also the console shows subtitles are found in both cases, ..including any other metadata it manages to fetch)

 

    1. Add something that has subtitles to the Seedbox either with the Download function or the Watch now function then abort playback.
    2. Start/restart playback from the Seedbox and see it doesn't find nor serve any subtitles.
@kiriles90 kiriles90 changed the title Fix ext. player/cast device subtitles for local files Fix ext. player/cast device subtitles for local files and subtitles for Seedbox Mar 22, 2024
@popcorn-official popcorn-official deleted a comment from merseyV Mar 22, 2024
@popcorn-official popcorn-official deleted a comment from merseyV Mar 22, 2024
@popcorn-official popcorn-official deleted a comment from merseyV Mar 22, 2024
@popcorn-official popcorn-official deleted a comment from merseyV Mar 22, 2024
@kiriles90 kiriles90 changed the title Fix ext. player/cast device subtitles for local files and subtitles for Seedbox Fix ext. player/cast device subtitles for local files and Seedbox subtitles Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

1 participant