From 05f813faa02542689eac86b7a933fd9dec77a75c Mon Sep 17 00:00:00 2001 From: Rory Logue <87331957+rorylogue@users.noreply.github.com> Date: Mon, 10 Jun 2024 15:54:54 +0100 Subject: [PATCH] fix: provide port base url as default and correct test action (#5) Our integrations were broken because: - A required parameter was added for the integration to work on the backend, but wasn't set as required in the GitHub action inputs: `pydantic.error_wrappers.ValidationError: 1 validation error for IntegrationConfiguration port -> base_url` - The required parameter `https://app.getport.io` should be `https://api.getport.io` I left it as a default to `https://api.getport.io` which makes sense to me but of course feel free to change. Adding an extra input for the API URL seems like it's not needed for the user if it's the same for everything. --- .github/workflows/test.yml | 1 - action.yml | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index f77c403..0e556a3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,7 +14,6 @@ jobs: type: 'jira' port_client_id: ${{ secrets.PORT_CLIENT_ID }} port_client_secret: ${{ secrets.PORT_CLIENT_SECRET }} - port_base_url: https://app.getport.io config: | jira_host: ${{ secrets.JIRA_HOST }} atlassian_user_email: ${{ secrets.JIRA_USER_EMAIL }} diff --git a/action.yml b/action.yml index 21f6847..0902bbe 100644 --- a/action.yml +++ b/action.yml @@ -18,6 +18,7 @@ inputs: required: true port_base_url: description: 'The Port base URL' + default: 'https://api.getport.io' required: false initialize_port_resources: description: 'Should Ocean try to create the default resources (blueprints, pages, integration config, etc.) provided with the integration'