From 8f3bd620ebab2febf71dc9d00f7ea3f5faba67da Mon Sep 17 00:00:00 2001
From: Ivan <62664893+ivankalinovski@users.noreply.github.com>
Date: Wed, 4 Dec 2024 15:35:14 +0200
Subject: [PATCH] =?UTF-8?q?[Core]=20Fix=20`apply-release.yml`=20and=20`bum?=
=?UTF-8?q?p-all.sh`=20to=20look=20on=20different=E2=80=A6=20(#1209)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
# Description
What -
Ocean version is not parsed
Why -
Because `pip index versions` return LATEST tag only when the package is
already installed.
How -
changed the one liner to refer the start of the output to parse ocean
version
## Type of change
Please leave one option from the following and delete the rest:
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)
All tests should be run against the port production
environment(using a testing org).
### Core testing checklist
- [ ] Integration able to create all default resources from scratch
- [ ] Resync finishes successfully
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Scheduled resync able to abort existing resync and start a new one
- [ ] Tested with at least 2 integrations from scratch
- [ ] Tested with Kafka and Polling event listeners
- [ ] Tested deletion of entities that don't pass the selector
### Integration testing checklist
- [ ] Integration able to create all default resources from scratch
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Resync finishes successfully
- [ ] If new resource kind is added or updated in the integration, add
example raw data, mapping and expected result to the `examples` folder
in the integration directory.
- [ ] If resource kind is updated, run the integration with the example
data and check if the expected result is achieved
- [ ] If new resource kind is added or updated, validate that
live-events for that resource are working as expected
- [ ] Docs PR link [here](#)
### Preflight checklist
- [ ] Handled rate limiting
- [ ] Handled pagination
- [ ] Implemented the code in async
- [ ] Support Multi account
## Screenshots
Include screenshots from your environment showing how the resources of
the integration will look.
## API Documentation
Provide links to the API documentation used for this integration.
Co-authored-by: Ivan Kalinovski
---
.github/workflows/apply-release.yml | 2 +-
scripts/bump-all.sh | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/apply-release.yml b/.github/workflows/apply-release.yml
index 74590e20a4..337f55d099 100644
--- a/.github/workflows/apply-release.yml
+++ b/.github/workflows/apply-release.yml
@@ -27,7 +27,7 @@ jobs:
- name: Get package version
id: version
run: |
- version=$(pip index versions port-ocean | grep LATEST | cut -d':' -f2 | sed 's/ //g')
+ version=$(pip index versions port-ocean | grep 'port-ocean' | cut -d' ' -f2 | tr -d '()')
pr_name="[Integration] Apply Ocean version $version to all integrations"
branch_name="apply-ocean-$version-to-all-integrations"
echo "Branch Name: $branch_name"
diff --git a/scripts/bump-all.sh b/scripts/bump-all.sh
index 5fff444b51..12a8ee8b12 100755
--- a/scripts/bump-all.sh
+++ b/scripts/bump-all.sh
@@ -3,7 +3,7 @@
SCRIPT_BASE="$(cd -P "$(dirname "$0")" && pwd)"
ROOT_DIR="$(cd -P "${SCRIPT_BASE}/../" && pwd)"
CURRENT_DIR=$(pwd)
-VERSION="^${1:-$(pip index versions port-ocean | grep LATEST | cut -d':' -f2 | sed 's/ //g')}"
+VERSION="^${1:-$(pip index versions port-ocean | grep 'port-ocean' | cut -d' ' -f2 | tr -d '()')}"
echo "Going to bump ocean core to version ${VERSION} for all integrations"