-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data from Peltola et al. 2023: Genetic admixture and language shift in the medieval Volga-Oka interfluve #151
Conversation
Thank you for your submission, @smpeltola! Could you please go through the checklist above and confirm that all requirements for the submission are met? You can click the checkboxes on the left to confirm an item. The automatic validation shows that your package includes duplicates of samples already published elsewhere: https://github.com/poseidon-framework/community-archive/actions/runs/7287175995/job/20086238835?pr=151
In our public archives we enforce unique Poseidon_IDs, so duplicates in new packages must be renamed. Are these samples from different individuals than the ones in |
Hi @nevrome, These are not the same individuals as in Saag 2021, they just happen to have the same ID. I'll come up with unique IDs and try again. |
Unique names for BOL001-003
Unique names for BOL001-003
Thanks for the submission @smpeltola, looking forward to getting those in. The ID duplication is annoying, but since we never made a resolution with the Tartu lab it's first-come-first-serve for any specific ID. |
Hmm, @nevrome, now the validation failed but I don't think I understand the error. Can you have a look? |
The error reads:
I understand this message as follows: The two large data files (.bim and .bed) were not correctly committed as Git LFS files, but as normal, Git-tracked files. Unfortunately this is not sufficient; as explained here. To fix this, the files have to be migrated to Git LFS. Please look here for instructions on how to install Git LFS. Then activate it in the repository with |
This looks now good to me - I think it can be merged. Thank you for preparing this, @smpeltola, and for addressing the minor technical issues! What's your final verdict, @AyGhal? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, great!
Would be awesome to also include an SSF file to this package. |
I don't think this should hold this up now. A .ssf file is purely optional and can easily be added later. @AyGhal Do you still have some concerns about this package? Otherwise I think it can be merged. |
I'm happy to add an SSF file later on, but don't hold up the merge for it. |
Thank you @smpeltola for making the package! And sorry that it took me so long to get back to it. It looks great. |
PR Checklist for a new package submission
POSEIDON.yml
conforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>
, e.g.2021_Zegarac_SoutheasternEurope
,2021_SeguinOrlando_BellBeaker
or2021_Kivisild_MedievalEstonia
.POSEIDON.yml
file with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion
,title
,description
,contributor
,packageVersion
,lastModified
(see here for their definition).janno
file (for a list of available fields look here and here for more detailed documentation about them)..bib
file with the necessary literature references for each sample in the.janno
file.POSEIDON.yml
file and there are no additional, supplementary files in the submission that are not documented there..janno
and.bib
file are all named after the package title and only differ in the file extension.POSEIDON.yml
file is1.0.0
.poseidonVersion
of the package in thePOSEIDON.yml
file is set to the latest version of the Poseidon schema.POSEIDON.yml
file contains the corresponding checksums for the fieldsgenoFile
,snpFile
,indFile
,jannoFile
andbibFile
.CHANGELOG
file or one with a single entry for version1.0.0
.Publication
column in the.janno
file is filled and the respective.bib
file has complete entries for the listed mentioned keys..janno
file does not include any empty columns or columns only filled withn/a
..janno
file adheres to the standard order as defined in the Poseidon schema here.trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).