Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package: 2023_OlaldeCarrion_Roman #13

Merged
merged 17 commits into from
Feb 28, 2024

Conversation

danimfernandes
Copy link
Contributor

@danimfernandes danimfernandes commented Feb 21, 2024

Closes #12

PR Checklist

  • Add the appropriate label to your PR (new package or package update).
  • The PR title is in the format Add/update package: {package_name}.
  • The PR description includes a link to the issue requesting the package its
    update. (Add to Closes #XXX above.)

If adding or updating a package:

  • This PR contains a sequencingSourceFile (.ssf) for the requested
    package.
  • The name of the .ssf file(s) matches the package name (i.e.
    packages/2023_my_package/2023_my_package.ssf).
  • Comment @delphis-bot create recipe to this pull request to awaken
    Poseidon's trusty helper. (This should be repeated whenever changes are
    made to the SSF file contents).

Delphis-bot will then add a number of files to the PR. Check that they are all
there:

  • The file packages/{package_name}/{package_name}.tsv was added to the PR.
  • The file packages/{package_name}/{package_name}.tsv_patch.sh was added
    to the PR from template.
  • The file packages/{package_name}/script_versions.txt was added to the
    PR.
  • The file packages/{package_name}/{package_name}.config was added to the
    PR from template.

Human validation

Package SSF file (*.ssf)

  • I confirm that the poseidon_IDs, udg, and library_built are filled
    and correct.
  • I made sure to leave notes where necessary to explain any special
    cases/judgement calls made for data entries.

Package TSV file (*.tsv)

  • I confirm that the UDG, Strandedness columns are correct for each
    library.
  • I confirm that the R1_target_file and R2_target_file columns point to
    the correct FastQ files for the library (i.e. consistent with SSF file).

Package config file (*.config)

The template config file includes a few TODO statements, and information about
them. Please ensure that you:

  • I have selected the appropriate config for the CaptureType of the package.
  • If any nf-core/eager parameters need to be altered from their defaults, I
    have added them within the params section at the end of the package
    config file.

@stschiff
Copy link
Member

Great, thanks for adding, @danimfernandes. Do you need help before closing the final todos in the list and calling Delphis-bot?

@danimfernandes
Copy link
Contributor Author

@delphis-bot create recipe

@danimfernandes
Copy link
Contributor Author

@delphis-bot create recipe

@danimfernandes
Copy link
Contributor Author

@delphis-bot create recipe

@danimfernandes
Copy link
Contributor Author

Great, thanks for adding, @danimfernandes. Do you need help before closing the final todos in the list and calling Delphis-bot?

I think everything is ready now! But do let me know if I need to do any other thing.

@danimfernandes
Copy link
Contributor Author

Could you eventually rename the whole package to "2023_OlaldeCarrion_Roman", since the paper did come out on the 7th of December 2023? Thanks!

@TCLamnidis TCLamnidis changed the title Add package: 2024_OlaldeCarrion_Roman Add package: 2023_OlaldeCarrion_Roman Feb 28, 2024
@TCLamnidis
Copy link
Member

@delphis-bot create recipe

@TCLamnidis TCLamnidis merged commit a5a97d6 into poseidon-framework:main Feb 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2023_OlaldeCarrion_Roman
3 participants