-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package: 2023_Rodriguez_Varela #32
Conversation
@delphis-bot create recipe |
Hey @Helsinki-Ronan! Thanks for submitting a recipe. I see this is still a draft PR, so I will not look into specifics, but I had a comment regarding the process.
You should create an issue to request the package before opening a PR to add the recipe. The issue is then used to track the progress of the processing and is closed (by us) only once the recipe output has been integrated into the minotaur-archive. 🙂 See https://www.poseidon-adna.org/#/minotaur?id=what-is-the-processing-status-of-the-package-i-requested Once the recipe is ready, please mark it as "Ready for review" and I will take a look. 😁 |
@Helsinki-Ronan There appear to be multiple formatting errors in the SSF file. |
Any update, @Helsinki-Ronan? Do you need help with this? |
@delphis-bot create recipe |
Review needed |
@delphis-bot create recipe |
Linked to #36
PR Checklist
new package
orpackage update
).Add/update package: {package_name}
.update. (Add to
Closes #XXX
above.)If adding or updating a package:
.ssf
) for the requestedpackage.
.ssf
file(s) matches the package name (i.e.packages/2023_my_package/2023_my_package.ssf
).@delphis-bot create recipe
to this pull request to awakenPoseidon's trusty helper. (This should be repeated whenever changes are
made to the SSF file contents).
Delphis-bot will then add a number of files to the PR. Check that they are all
there:
packages/{package_name}/{package_name}.tsv
was added to the PR.packages/{package_name}/{package_name}.tsv_patch.sh
was addedto the PR from template.
packages/{package_name}/script_versions.txt
was added to thePR.
packages/{package_name}/{package_name}.config
was added to thePR from template.
Human validation
Package SSF file (
*.ssf
)poseidon_IDs
,udg
, andlibrary_built
are filledand correct.
notes
where necessary to explain any specialcases/judgement calls made for data entries.
Package TSV file (
*.tsv
)UDG
,Strandedness
columns are correct for eachlibrary.
R1_target_file
andR2_target_file
columns point tothe correct FastQ files for the library (i.e. consistent with SSF file).
Package config file (
*.config
)The template config file includes a few
TODO
statements, and information aboutthem. Please ensure that you:
have added them within the
params
section at the end of the packageconfig file.