From 90d9548cfa24b25ceb07275a05c0bd45b8d85218 Mon Sep 17 00:00:00 2001 From: Marie Idleman Date: Sat, 25 Jan 2025 15:25:36 -0600 Subject: [PATCH] test fail/flakes --- .github/workflows/test-pull-request.yml | 1 + test/e2e/tests/console/console-ansi.test.ts | 8 +++++++- test/e2e/tests/editor-action-bar/document-files.test.ts | 1 - 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-pull-request.yml b/.github/workflows/test-pull-request.yml index f037d75e3ae..8ed1a1cecf0 100644 --- a/.github/workflows/test-pull-request.yml +++ b/.github/workflows/test-pull-request.yml @@ -77,6 +77,7 @@ jobs: secrets: inherit slack-notify: + if: always() needs: [e2e-linux-electron] #, e2e-windows-electron, e2e-linux-browser] runs-on: ubuntu-latest steps: diff --git a/test/e2e/tests/console/console-ansi.test.ts b/test/e2e/tests/console/console-ansi.test.ts index 8d6997972d6..b91a58c2e56 100644 --- a/test/e2e/tests/console/console-ansi.test.ts +++ b/test/e2e/tests/console/console-ansi.test.ts @@ -16,6 +16,7 @@ test.describe('Console ANSI styling', { tag: [tags.CRITICAL, tags.CONSOLE, tags. }); test("R - Can produce clickable file links", async function ({ app, r }) { + expect(1).toBe(2); // Can be any file on the workkspace. We use .gitignore as it's probably // always there. const fileName = '.gitignore'; @@ -35,7 +36,12 @@ test.describe('Console ANSI styling', { tag: [tags.CRITICAL, tags.CONSOLE, tags. }).toPass({ timeout: 60000 }); }); - test("R - Can produce clickable help links", async function ({ app, r }) { + test("R - Can produce clickable help links", async function ({ app, r }, testInfo) { + if (testInfo.retry) { + expect(2).toBe(2); // Intentionally fail + } else { + expect(1).toBe(2); // Pass + } const inputCode = `cli::cli_inform("{.fun base::mean}")`; await expect(async () => { diff --git a/test/e2e/tests/editor-action-bar/document-files.test.ts b/test/e2e/tests/editor-action-bar/document-files.test.ts index a405638e625..0033747d2b7 100644 --- a/test/e2e/tests/editor-action-bar/document-files.test.ts +++ b/test/e2e/tests/editor-action-bar/document-files.test.ts @@ -30,7 +30,6 @@ test.describe('Editor Action Bar: Document Files', { test('R Markdown Document', { tag: [tags.R_MARKDOWN] }, async function ({ app, openFile }) { - expect(1).toBe(2); await openFile('workspaces/basic-rmd-file/basicRmd.rmd'); await verifyPreviewRendersHtml('Getting startedAnchor'); await verifySplitEditor('basicRmd.rmd');