Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Modal Dialog Button Placement and Default Acceptance #3548

Closed
petetronic opened this issue Jun 14, 2024 · 3 comments
Closed

Review Modal Dialog Button Placement and Default Acceptance #3548

petetronic opened this issue Jun 14, 2024 · 3 comments
Assignees
@dhruvisompura
Labels
area: ui Issues related to UI category.
Milestone
2025.02.0 Pre-Rel...

Comments

@petetronic
Copy link
Collaborator

petetronic commented Jun 14, 2024 •
edited
Loading

Feedback from a UX review of the private beta:
Positron is starting to accumulate modal dialogs, however the placement of the buttons and the location of the "default" operation are inconsistent between them. We need to review each of the dialogs and try to align them in a more coherent manner.
@petetronic petetronic added the area: ui Issues related to UI category. label Jun 14, 2024
@petetronic petetronic added this to the Release Candidate milestone Jun 19, 2024
@juliasilge juliasilge mentioned this issue Dec 16, 2024
Open
@petetronic
Copy link
Collaborator Author

See Miro.

@dhruvisompura dhruvisompura self-assigned this Dec 19, 2024
@dhruvisompura dhruvisompura mentioned this issue Jan 17, 2025
Merged
5 tasks
dhruvisompura added a commit that referenced this issue Jan 22, 2025
@dhruvisompura @sharon-wang
Match dialog button layout to OS (#6044)
b07fed2 
This change updates the order of buttons in modals to match a user's
native OS layout. The layout of buttons defaults to OS X button order
when Positron is run in a web environment.

Addresses #3548 

### Release Notes

#### New Features

- Updates modal button order to match native OS layout 

#### Bug Fixes

- N/A


### QA Notes
- [ ] Verify that keyboard navigation works for modals and there are no
regressions with the behavior
- [ ] Verify that confirmation dialogs with an Ok and Cancel button is
ordered:
  - [ ]  Ok/Cancel on windows
  - [ ] Cancel/Ok on non-windows environments
- [ ] Verify that dialogs with more than two actions split actions so
that the primary action and cancel action are positioned at the right
end of the modal and all other tertiary actions are positioned at the
left end of the modal.

### Screenshots

<img width="1346" alt="Screenshot 2025-01-17 at 12 21 03 PM"
src="https://github.com/user-attachments/assets/e71a93d5-33ce-4ea2-bafa-795bca7a222b"
/>

<img width="1346" alt="Screenshot 2025-01-17 at 12 20 47 PM"
src="https://github.com/user-attachments/assets/875680fe-d187-4040-9661-4621a1f93621"
/>

<img width="1346" alt="Screenshot 2025-01-17 at 12 20 17 PM"
src="https://github.com/user-attachments/assets/1fe06f71-e1ed-4d7d-bb18-c478ee6e5896"
/>

<img width="1346" alt="Screenshot 2025-01-17 at 12 20 09 PM"
src="https://github.com/user-attachments/assets/58fea0e7-6b00-46cf-aa8f-9350ea96f7ac"
/>


https://github.com/user-attachments/assets/92b72df1-d87f-4e45-8982-52d8f01825b1

@:new-project-wizard @:win @:modal

---------

Signed-off-by: Dhruvi Sompura <[email protected]>
Co-authored-by: sharon <[email protected]>
@jonvanausdeln
Copy link
Contributor

I found that tabbing around the save plot dialog isn't working as it used to. It only cycles between directory, browse button, and name field. It used to cycle through all the fields.

Old behavior:

Old.tab.behavoir.mp4

New behavior:

new.tab.behavior.mp4

@jonvanausdeln jonvanausdeln mentioned this issue Jan 24, 2025
Open
@jonvanausdeln
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2025.02.0-112
OS Version(s) : Windows 11

Test scenario(s)

All modals look correct and function as expected. The notable exception is save plot dialog (see above comment), that is tracked in new issue #6121

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvisompura dhruvisompura

Labels
area: ui Issues related to UI category.
Projects
None yet
Milestone
2025.02.0 Pre-Release
Development

No branches or pull requests
3 participants
@petetronic @dhruvisompura @jonvanausdeln