Reindenting lines only removes all indentation

[andrewheiss]

Positron Version:

Positron Version: 2024.07.0 (Universal) build 15
Code - OSS Version: 1.90.0
Commit: d8da3ec
Date: 2024-07-05T03:51:32.592Z
Electron: 29.4.0
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

Steps to reproduce the issue:

1. Enable RStudio keybindings
2. Select R code that isn't consistently indented
3. Type cmd + i or use the "Reindent lines" command from the Command Palette
4. All line indentation is removed

Here's a quick video:

positron-reindent.mov

What did you expect to happen?

In RStudio, the same command results in code that is indented:

rstudio-reindent.mov

Were there any error messages in the output or Developer Tools console?

Nope.

[andrewheiss]

Actually, it seems to do this just for pipes and ggplot +s. Arguments inside parentheses get aligned correctly:

indent-arguments.mov

This might be related to #1316, though that was for indent-as-you-type indentation

[juliasilge]

This is related to #19 where we realized that the "reindent lines" command uses a whole separate code path. We will be solving this via a real formatter for R, rather than the rudimentary styler + indent-only formatter we have now.

Let's keep this issue open for the cases to check. 👍