Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consult PATH for R before "miscellaneous locations" #5220

Closed
jennybc opened this issue Oct 30, 2024 · 1 comment
Closed

Consult PATH for R before "miscellaneous locations" #5220

jennybc opened this issue Oct 30, 2024 · 1 comment
Assignees
Labels
area: runtimes Issues related to Language Runtimes lang: r

Comments

@jennybc
Copy link
Member

jennybc commented Oct 30, 2024

This is mostly a note to myself. I want to hoist the PATH check earlier in the process. This will not affect what we discover, but will affect our attribution re: how we discovered something. Again, that info is not yet exposed anywhere, but eventually it might be in some form (see #5223).

I'm talking about reordering this:

// other conventional places we might find an R binary (or a symlink to one)

and this:

const pathBinary = await findRBinaryFromPATH();

@jennybc jennybc added area: runtimes Issues related to Language Runtimes lang: r labels Oct 30, 2024
@jennybc jennybc self-assigned this Oct 30, 2024
@jennybc jennybc added this to the 2024.12.0 Pre-Release milestone Oct 30, 2024
jennybc added a commit that referenced this issue Dec 10, 2024
…5648)

Addresses #1397 
Addresses #5220 
Continued preparation for #5223

A lot of the changes are very internal, but there are also user-facing
improvements:

* Even more effort to track the reasons (plural) why we've discovered an
R installation and, perhaps, the reason an R installation can't be used
with Positron. The richer information appears in the Positron R
Extension output channel.
* If we discover at least one R installations, but there is no usable R
installation, we put a pop-up warning. The exact details of this will be
good to discuss in the next R meeting.

### QA Notes

To experience this, you need to have at least 1 unusable R installation
around and 0 usable ones.

For rig-installed R, use `rig rm release` (or similar) to remove an R
installation. Repeat as necessary, until all usable R is gone!

Older R installers are here for macOS arm64:
https://cran.rstudio.com/bin/macosx/big-sur-arm64/base/. This makes it
easy to get R 4.1, for example, which is below our minimum supported
version.

You should see a modal telling you that all R installations are
unusable, allowing you to look at the Positron R Extension output
channel or dismiss.

---------

Signed-off-by: Jennifer (Jenny) Bryan <[email protected]>
Co-authored-by: Chris Mead <[email protected]>
Co-authored-by: Julia Silge <[email protected]>
@jennybc
Copy link
Member Author

jennybc commented Dec 11, 2024

There really isn't anything to verify here (it's an internal matter), so I'm going to close.

@jennybc jennybc closed this as completed Dec 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: runtimes Issues related to Language Runtimes lang: r
Projects
None yet
Development

No branches or pull requests

1 participant