Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Github PAT optional when downloading binaries from public repositories #6083

Open
jmcphers opened this issue Jan 22, 2025 · 0 comments
Open
Labels
area: builds Issues related to Builds category.

Comments

@jmcphers
Copy link
Collaborator

We currently require a Github PAT in order to download Positron's pre-built binaries (including Kallichore, ARK, and perhaps PET soon), despite the fact that these binaries are in public repositories that don't need a Github PAT to access.

It is still helpful to supply a PAT for e.g. rate limiting purposes, but requiring one needlessly complicates the process of getting Positron built on a new machine (especially for third-party contributors or others who do not need to build frequently).

The download scripts for these binaries should use a PAT if one is available, but proceed to download without one otherwise.

@jmcphers jmcphers added the area: builds Issues related to Builds category. label Jan 22, 2025
@juliasilge juliasilge added this to the 2025.05 Pre-Release milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: builds Issues related to Builds category.
Projects
None yet
Development

No branches or pull requests

2 participants