Support link underlines accessibility setting #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
dotNomad
force-pushed
the
dotnomad/link-underlines
branch
from
0806bcc
to
80bca9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode
1.91.0added a new settingaccessibility.underlineLinkswhich does what it says on the tinhttps://code.visualstudio.com/updates/v1_91#_link-underlines
This PR ensures all of our text links (
<a>) support the feature and toggle appropriately.Preview
CleanShot.2024-07-03.at.15.00.56.mp4
Intent
Resolves #1934
Type of Change
Approach
The injected CSS does the below
The
--text-link-decorationvariable changes based on the setting.To support this, anywhere do an text anchor link we could use that CSS variable, or if it is text we can wrap the anchor in a
pelement. I did the latter here.