Remove unused command code #2569
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosnav
approved these changes
Jan 30, 2025
dotNomad
reviewed
Jan 30, 2025
dotNomad
reviewed
Jan 31, 2025
There was a problem hiding this comment.
Once we get CI passing this is looking good. Agreed with @marcosnav, lets get those comments cleaned up 🔥
|
To get CI to pass, we have to merge #2584 first. That PR is waiting on replacement tests for what it is removing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Removes legacy CLI commands which are not needed for VSCode extension
Resolves #2521
Type of Change
Approach
The VSCode extension executes the agent with the following command parameters:
<agent> UI -vv --listen <port>It is also useful to support
<agent> versionI removed the CLI commands within the
konginfrastructure and then trimmed down the sub-commands locatedwithin the UI command. There were a few impacts to the httpserver that we are setting up, but that was for features which were not in use.
User Impact
The user should see no difference other than when executing
<agent> -h(help).Automated Tests
Bat tests have been removed, which were what was executing the CLI. This was done in a different PR (#2558)
Directions for Reviewers
Build checks and CI should pass. Manual tests should be performed to just make sure the UX is able to communicate with the agent.
Checklist