Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case sensitive routes cause folder duplication #20

Open
zjrunner opened this issue Oct 17, 2018 · 1 comment
Open

Case sensitive routes cause folder duplication #20

zjrunner opened this issue Oct 17, 2018 · 1 comment

Comments

@zjrunner
Copy link

Routes shouldn't be case sensitive. in helpers.js@getTreeFromPaths we can just index treeNode with the thisPath[I].toUpperCase() to consolidate, it doesn't bleed into the output at the end.

I have a PR in a fork I'll attach later if acceptable as a change.

@Dhroov7
Copy link
Contributor

Dhroov7 commented Jul 11, 2019

@zjrunner as per RFC3986 (https://tools.ietf.org/html/rfc3986#section-6.2.2.1) paths in URI can be case sensitive. So, that means case sensitive routes leads to different results.Hence creating multiple folders is the ideal way to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants