Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base URLs Don't Encode Properly Without Terminating Slash #22

Open
tmountain opened this issue Dec 8, 2022 · 1 comment
Open

Base URLs Don't Encode Properly Without Terminating Slash #22

tmountain opened this issue Dec 8, 2022 · 1 comment

Comments

@tmountain
Copy link

DEFAULT_SETTINGS = {
    "base_open_tracking_url": "http://pixels.example.com/track/",
    "base_click_tracking_url": "http://clicks.example.com/track?"
}

Given the example above, the base_open_tracking_url looks like this (correct):

http://pixels.example.com/track/

The base_click_tracking_url excludes the track? portion.

http://clicks.example.com/eyJ1cmwiOiAia...

The base URL should accommodate both scenarios.

@flaiming
Copy link

I'm also quite bothered by this issue and would vote for accommodating both scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants