From 864e1e1e3b9753c884b94ad6d30b7a24cb5eabb2 Mon Sep 17 00:00:00 2001 From: nickamantia Date: Thu, 26 Sep 2024 11:48:44 -0400 Subject: [PATCH] addressing feedback --- .../app/pb_kits/playbook/pb_dropdown/_dropdown.tsx | 4 ++-- .../pb_dropdown/docs/_dropdown_subtle_variant.jsx | 14 +++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.tsx b/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.tsx index b7df8eaf0a..a8fb292c37 100644 --- a/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.tsx +++ b/playbook/app/pb_kits/playbook/pb_dropdown/_dropdown.tsx @@ -36,7 +36,7 @@ type DropdownProps = { onSelect?: (arg: GenericObject) => null; options: GenericObject; triggerRef?: any; - variant?: string; + variant?: "primary" | "subtle"; }; const Dropdown = (props: DropdownProps) => { @@ -57,7 +57,7 @@ const Dropdown = (props: DropdownProps) => { onSelect, options, triggerRef, - variant + variant = "primary" } = props; const ariaProps = buildAriaProps(aria); diff --git a/playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx b/playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx index 74b5e5eb00..a9bbc0be3d 100644 --- a/playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx +++ b/playbook/app/pb_kits/playbook/pb_dropdown/docs/_dropdown_subtle_variant.jsx @@ -20,13 +20,13 @@ const DropdownSubtleVariant = (props) => { return ( -
- -
+ <> + + ) }