Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameObects need to have a parent #666

Open
pathunstrom opened this issue Feb 5, 2022 · 2 comments
Open

GameObects need to have a parent #666

pathunstrom opened this issue Feb 5, 2022 · 2 comments
Labels
Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB

Comments

@pathunstrom
Copy link
Collaborator

In an effort to support relative positioning inside of #577 we're going to need to break a fundamental assumption of ppb: objects need to know the container they live in. Since we have the gomlib now, we don't need to worry about this.

Add a self._parent as a weak reference to the containing GameObject, then when a GameObject is added to another, set the child._parent to the container. When you remove a GameObject from another, set that reference to None.

@pathunstrom pathunstrom added Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB labels Feb 5, 2022
@AstraLuma
Copy link
Member

I believe @avarice-m said in discord faer would be working on this.

@jonesmat
Copy link

@pathunstrom does this still need to be done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Good issues for Hacktoberfest (synced with new contributor) new contributor Apply to issues we think can be tackled by people new to PPB
Projects
None yet
Development

No branches or pull requests

3 participants