-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Check if a condition is met before the polling interval has elapsed. #676
Comments
/good-first-issue |
@kishen-v: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
…ion. Fixed ppc64le-cloud#676: Validate conditions immediately upon invocation.
…ion. Fixed ppc64le-cloud#676: Validate conditions immediately upon invocation.
…ion. Fixed ppc64le-cloud#676: Validate conditions immediately upon invocation.
…ion. Fixed ppc64le-cloud#676: Validate conditions immediately upon invocation.
/remove-kind bug |
What happened:
An instant first
tick
is preferred over long running operations, which may have a particular condition satisfied already.pvsadm/pkg/utils/utils.go
Lines 59 to 71 in d2d3bd1
What you expected to happen:
The condition to be checked once when the function is invoked, to cut down on waiting for a condition that may already be achieved.
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
https://stackoverflow.com/questions/32705582/how-to-get-time-tick-to-tick-immediately
Environment:
pvsadm --version
):cat /etc/os-release
):uname -a
):The text was updated successfully, but these errors were encountered: