Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate conditions immediately upon invocation. #678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate conditions immediately upon invocation. #678

wants to merge 1 commit into from

Conversation

aman4433
Copy link

fixes : #676
Validate conditions immediately upon invocation.

I0927 03:24:02.531498  835123 import.go:258] Importing image rhel-94-04242024-tier0. Please wait...
I0927 03:24:06.596504  835123 import.go:277] Image import is in-progress, current state: queued
I0927 03:26:06.680951  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:28:06.623011  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:30:06.843204  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:32:06.727223  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:34:06.769074  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:36:06.920080  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:38:06.861958  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:40:06.951969  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:42:06.826810  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:44:06.873676  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:46:06.901292  835123 import.go:271] Image imported successfully, took 22m0.670579377s
I0927 03:46:06.901342  835123 import.go:285] Retrieving image details
I0927 03:46:09.835499  835123 import.go:298] Waiting for image rhel-94-04242024-tier0 to be active. Please wait...
I0927 03:46:11.881238  835123 import.go:306] Successfully imported the image: rhel-94-04242024-tier0 with ID: bf824a64-2e34-49f0-8c05-1f91ab20c6ec in 2.045705864s

@ppc64le-cloud-bot ppc64le-cloud-bot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 27, 2024
@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aman4433
Once this PR has been reviewed and has the lgtm label, please assign mkumatag for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot
Copy link
Contributor

Welcome @aman4433! It looks like this is your first PR to ppc64le-cloud/pvsadm 🎉

@ppc64le-cloud-bot ppc64le-cloud-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2024
@ppc64le-cloud-bot
Copy link
Contributor

Hi @aman4433. Thanks for your PR.

I'm waiting for a ppc64le-cloud member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 27, 2024
@aman4433 aman4433 force-pushed the feature/optimize-condition-check branch from c77e17b to 85c06be Compare September 27, 2024 09:51
@aman4433 aman4433 changed the title Fixed #676: Validate conditions immediately upon invocation. Validate conditions immediately upon invocation. Sep 27, 2024
@ppc64le-cloud-bot ppc64le-cloud-bot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Sep 27, 2024
@kishen-v
Copy link
Contributor

/ok-to-test

@ppc64le-cloud-bot ppc64le-cloud-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkhadars bkhadars Awaiting requested review from bkhadars

@Rajalakshmi-Girish Rajalakshmi-Girish Awaiting requested review from Rajalakshmi-Girish

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Check if a condition is met before the polling interval has elapsed.
3 participants
@aman4433 @ppc64le-cloud-bot @kishen-v