Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version? #350

Closed
kloczek opened this issue Jun 1, 2022 · 19 comments
Closed

New version? #350

kloczek opened this issue Jun 1, 2022 · 19 comments

Comments

@kloczek
Copy link

kloczek commented Jun 1, 2022

ppp-2.4.9...master shows already +130 commits.
It is always better to make release with smaller batches of commits.
Please consider to make the new release soon.

@Neustradamus
Copy link
Member

@kloczek: I think that it will be nice to have a perfect @EasyNetDev PR before it :/

@Neustradamus
Copy link
Member

Neustradamus commented Dec 27, 2022

I think last PRs before the new build will be:

@Neustradamus
Copy link
Member

@paulusmack: About the Debian 12 freeze deadline:

cc: @bootc.

@paulusmack
Copy link
Collaborator

I think we're very close to being able to do a release; it's mostly now a matter of writing some release notes to go into the README file and then creating the tarballs and putting them up.

I'd like to hear from the contributors to this release if there are any particular items that should be mentioned in the README.

@carlsonj could you check that all appears to be OK on Solaris please?

@yarda
Copy link
Contributor

yarda commented Jan 22, 2023

@enaess, @jjkeijser, @jkroonza, @bootc, @rfc1036, @yarda, @dfskoll: ^

LGTM, thanks. I have no particular requirements regarding the release notes.

@enaess
Copy link
Contributor

enaess commented Jan 23, 2023

@thesamesam how does current PPP/master compile on Gentoo with the latest GCC (as you found with sstp-client)?

@thesamesam
Copy link
Contributor

@thesamesam how does current PPP/master compile on Gentoo with the latest GCC (as you found with sstp-client)?

Cheers for the ping! Let me have a look either tomorrow or day after.

@jkroonza
Copy link
Contributor

jkroonza commented Jan 23, 2023

jkroon@plastiekpoot ~/projects/ppp (master) $ ./configure
...
ppp version 2.5.0
    Prefix...............: /usr/local
    Runtime Dir..........: ${localstatedir}/run/pppd
    Logfile Dir..........: ${prefix}/var/log/ppp
    Plugin Dir...........: ${exec_prefix}/lib/pppd/2.5.0
    With OpenSSL.........: yes
    With libatm..........: no
    With libpam..........: yes
    With libpcap.........: yes
    With libsrp..........: no
    C Compiler...........: gcc -g -O2
    Linker...............: /usr/x86_64-pc-linux-gnu/bin/ld -m elf_x86_64  

Features enabled
    Microsoft Extensions.: yes
    Multilink............: no
    Plugins..............: yes
    CBCP.................: no
    IPV6CP...............: yes
    EAP-TLS..............: yes
    PEAP.................: yes
    systemd notifications: no
jkroon@plastiekpoot ~/projects/ppp (master) $ make -j16
...
make[2]: Leaving directory '/home/jkroon/projects/ppp/pppd/plugins'
make[1]: Leaving directory '/home/jkroon/projects/ppp/pppd/plugins'
make[1]: Entering directory '/home/jkroon/projects/ppp'
make[1]: Nothing to be done for 'all-am'.
make[1]: Leaving directory '/home/jkroon/projects/ppp'
jkroon@plastiekpoot ~/projects/ppp (master) $ 

@thesamesam is there anything else you'd like to test specifically? I've run pppoe-server with this as well on my test host, and I'm fairly certain if there are problems I'll be able (and more than willing to ... time permitting which since you're pinging me on other bugs know is fairly limited).

jkroon@plastiekpoot ~ $ gcc -v
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/11/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /var/tmp/portage/sys-devel/gcc-11.3.1_p20221209/work/gcc-11-20221209/configure --host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr --bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/11 --includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/11/include --datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/11 --mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/11/man --infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/11/info --with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/11/include/g++-v11 --with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/11/python --enable-languages=c,c++ --enable-obsolete --enable-secureplt --disable-werror --with-system-zlib --enable-nls --without-included-gettext --disable-libunwind-exceptions --enable-checking=release --with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo 11.3.1_p20221209 p3' --with-gcc-major-version-only --disable-esp --enable-libstdcxx-time --disable-libstdcxx-pch --enable-shared --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-multilib --with-multilib-list=m32,m64 --disable-fixed-point --enable-targets=all --enable-libgomp --disable-libssp --disable-libada --disable-cet --disable-systemtap --disable-valgrind-annotations --disable-vtable-verify --disable-libvtv --without-zstd --enable-lto --without-isl --enable-default-pie --enable-default-ssp
Thread model: posix
Supported LTO compression algorithms: zlib
gcc version 11.3.1 20221209 (Gentoo 11.3.1_p20221209 p3) 

@thesamesam
Copy link
Contributor

@jkroonza The main task is to just port the ebuild to autotools and see if everything works okay, or if we're missing some way to do something we used to do in the new setup. Ideally someone who uses ppp could do that (you? 😀) at least for a first pass, then I could tidy it up if needed.

@jkroonza
Copy link
Contributor

I can build it standalone from master branch, so if a release is made I'm sure I'll be able to port the ebuild, hopefully including most patches that wasn't merged upstream (and with permission from original authors ideally submit them here too). If any individual patch gets stuck we should probably also evaluate if it's a required patch, ie, reach out or block it temporarily with a news item. That's Gentoo problems though, not ppp, and IMHO shouldn't be a cause for blocking a new release. If we need assistance from ppp I'm sure we will be able to motivate a 2.5.1 release.

@paulusmack
Copy link
Collaborator

I think the tree is ready for release. Last call for anything that really needs to be fixed before 2.5.0...

@paulusmack
Copy link
Collaborator

2.5.0 is out there now.

@Neustradamus
Copy link
Member

Dear all,

@paulusmack will prepare a 2.5.1 release build and ask some questions:

Can you look it?

Thanks in advance.

@Neustradamus
Copy link
Member

Neustradamus commented Sep 18, 2024

PPP 2.5.1 has been released (2024-09-18)

@Neustradamus
Copy link
Member

Dear all,

@paulusmack has planned a new build in few days, you have not patches?

@bootc, @rfc1036: What is the latest date to have a new PPP version (2.5.2) in Debian Testing before Debian 13 freeze?

@dfskoll
Copy link
Contributor

dfskoll commented Dec 30, 2024

Are any patches required?

@jkroonza
Copy link
Contributor

Are any patches required?

Highly doubt it. No functional changes, mostly relatively minor fixes, and one change to actually expose functionality rp-pppoe already implements to the ppp user scripts.

@Neustradamus
Copy link
Member

PPP 2.5.2 has been released (2024-12-31)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

8 participants