Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring with --enable-microsoft-extensions=no breaks the compile #523

Closed
paulusmack opened this issue Sep 30, 2024 · 3 comments · Fixed by #540
Closed

Configuring with --enable-microsoft-extensions=no breaks the compile #523

paulusmack opened this issue Sep 30, 2024 · 3 comments · Fixed by #540

Comments

@paulusmack
Copy link
Collaborator

After configuring with --enable-microsoft-extensions=no, running make gives:

  CC       pppd-peap.o
peap.c: In function ‘peap_init’:
peap.c:522:12: error: ‘struct peap_state’ has no member named ‘chap’
  522 |         psm->chap = chap_find_digest(CHAP_MICROSOFT_V2);
      |            ^~
make[2]: *** [Makefile:1520: pppd-peap.o] Error 1

@enaess ?

@enaess
Copy link
Contributor

enaess commented Oct 11, 2024

If you disable Microsoft extensions then you might as well disable peap in the configuration too. Mschap is the only working peap method at this point.

@paulusmack
Copy link
Collaborator Author

So then we should make peap depend on ms-extensions at the configure stage...

@enaess
Copy link
Contributor

enaess commented Oct 15, 2024

@paulusmack for the time being, I think that would be appropriate. There might be a time in the future someone would add e.g. PEAP-SHA1 or something similar, which should allow configuring PEAP with whatever it supports. But since MsChapv2 is the only supported PEAP mechanisms now, then yes ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants