From 6e605d7e505670c5f95cfb04d2cb98e8ad7902b6 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 26 Sep 2024 15:31:10 +0900 Subject: [PATCH] Add note about why we're providing a custom `signTemplate` --- Builders/WindowsBuilder.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Builders/WindowsBuilder.cs b/Builders/WindowsBuilder.cs index 6f30023..42c6d13 100644 --- a/Builders/WindowsBuilder.cs +++ b/Builders/WindowsBuilder.cs @@ -39,6 +39,10 @@ public override Uploader CreateUploader() if (dllPath == null) Logger.Error("Could not find path for Dlib.dll"); + // We're using `signTemplate` here as we need to prefer the system `signtool.exe` in order for it to + // run azure code signing correctly on older windows versions. + // + // This can be changed back to `signParams` if velopack changes the signtool logic to fix this. string signToolPath = Directory.GetDirectories(@"C:\Program Files (x86)\Windows Kits\10\bin", "*", SearchOption.AllDirectories) .Select(dir => Path.Combine(dir, @"x64\signtool.exe")) .Where(File.Exists)