Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strings are reported to be localisable when return type is string #52

Open
smoogipoo opened this issue Jun 6, 2022 · 2 comments
Open

Strings are reported to be localisable when return type is string #52

smoogipoo opened this issue Jun 6, 2022 · 2 comments

Comments

@smoogipoo
Copy link
Collaborator

See: karaoke-dev/karaoke#1265 (comment)

It should not suggest that the string is localisable when the return type is a string.
@peppy
Copy link
Member

peppy commented Jun 6, 2022

I think this sounds okay. We have pretty good LocalisableString coverage these days. A few cases may be missed but that's not a huge deal.

@smoogipoo
Copy link
Collaborator Author

It's a "nice to have" priority level for sure. Mostly for external/.NET code that doesn't support LocalisableString.

@smoogipoo smoogipoo mentioned this issue Jun 6, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@peppy @smoogipoo