I think the OS rotation lock is enough? This will cause a UX problem if we disable rotation in certain screens (i.e. gameplay), or settings bloat if we make it toggleable.

Also to note, I don't see a gameplay benefit with rotating in the middle of play, only a disadvantage if screen accidentally rotates (which OS rotation lock is there for).

This has recently been fixed on android to respect the user rotation lock setting. It has always done so on iOS.

Agree that we may want to block rotation during gameplay (when LocalUserActive) though.

This turned out to be extremely convoluted for multiple reasons, in a cascading manner:

• UIKit does not directly support locking current screen orientation
• UIKit allows controlling the allowed screen orientations dynamically by overriding supportedInterfaceOrientations and returning a different mask if the game is requesting a lock, but I can't directly override on the root view controller class as it is prepared and provided by SDL.
• SDL overrides rootViewController.supportedIntefaceOrientations and reads the hint value of SDL_HINT_ORIENTATIONS there, so sounds like we're winning right? we can just set the hint whenever we want and it'll just work...right? So that actually just doesn't work, whatever value I set there is still bypassed and the game can still freely rotate around.
• Random google searches show that we can control the orientation on a higher level by overriding UIApplicationDelegate.supportedInterfaceOrientationsForWindow:, but...since we migrated to SDL, we can no longer override any method of the app delegate, as the app delegate is privately set up by SDL.

I can double down and start inventing Obj-C weirdness to make SDL use a custom app delegate subclass we provide, but that is not simple to achieve at all. As such, I've just un-assigned as not worth the time/effort for now.

I'm guessing now that you have an AppDelegate again this becomes more feasible?

Yeah I'll look into this again.