Error in call to 'setup' with multiple arguments

[olgeni]

On iohyve 0.7.9 from FreeBSD ports, I tried the following:

iohyve setup pool=rpool net=re0

It will work, but with this output:

[: pool=rpool: unexpected operator

It turns out that ioh-setup has a check in __setup that expands to an incorrect syntax:

     if [ -z "$@" ]; then
            echo "Please specify setup parameters."
            echo "Usage: 'iohyve setup <pool=poolname> [kmod=0|1] [net=iface]'"
            echo "See man page for details."
            exit 1
    fi

Using sh -x you see the following happening:

+ __setup setup 'pool=rpool' 'net=re0'
+ shift 1
+ local 'args=pool=rpool net=re0'
+ local poolval
+ local kmodval
+ local netval
+ [ -z 'pool=rpool' 'net=re0' ]
[: pool=rpool: unexpected operator

"$@" is expanded to multiple arguments and the -z syntax is then broken.

This doesn't seem to affect the setup process.

[pr1ntf]

Thank you for the detailed report and suggested fix! We'll take a look.