Debian LVM support broken by PR 255

[ntompson]

I've recently upgraded my FreeNAS system from 9.10 to 11.1. In doing so, I've received an update from iohyve 0.7.7 to 0.7.9. My existing Debian LVM VMs fail to start in 11.1, falling through to the grub prompt. After sifting through source code, I can see that when Ubuntu support was added (#255), d8lvm was borked.

Looking at the changes, I can see that an additional switch was correctly created for ubuntu for the case where $install = "yes" (line 369 in latest source code), but replaced d8lvm for the case where $install = "no" (line 425).

Consequently, when trying to run a VM with os="d8lvm", execution falls out of the os check and into a default grub-bhyve statement, which is incorrect for starting a Debian LVM VM. End result is a grub prompt rather than a running VM.

I think I will be able to get my VMs going under 11.1 by using os="ubuntu", but I haven't tested this yet, and am concerned there may be side effects. It would be good to get the d8lvm support corrected.

[orbitz]

I've just gotten Ubuntu working, I tracked down the issue to Ubuntu installs on (hd0,gpt2) but bhyve is started with (hd0,msdos1). I modified the ioh-guest code to force it to be (hd0,gpt2) and it booted.