Fixes wrong already running/loaded messages. #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition where iohyve will fail to start a bhyve instance when there is a running iohyve with the prefix of the same name as the iohyve you are trying to start. e.g. (you have `example-other` running): `iohyve start example` Will fail with the error message: ``` This guest appears to be already running/loaded. Use stop, destroy, or forcekill to remove zombie processes. ``` This corrects the pgrep regexs to stop matching past the name.
derekmarcotte
force-pushed
the
dm-fix-prefix-match
branch
from
a9fbf77
to
83056f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: This guest appears to be already running/loaded.
There is a race condition where iohyve will fail to start a bhyve
instance when there is a running iohyve with the prefix of the same name
as the iohyve you are trying to start.
e.g. (you have
example-otherrunning):iohyve start exampleWill fail with the error message:
This corrects the pgrep regexs to stop matching past the name.