Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taken tickets should trigger spawner #32

Open
praiskup opened this issue May 7, 2020 · 1 comment
Open

taken tickets should trigger spawner #32

praiskup opened this issue May 7, 2020 · 1 comment
Labels
enhancement RFE, feature

Comments

@praiskup
Copy link
Owner

praiskup commented May 7, 2020

Even though I have this:

aws_x86_64_normal:
    max: 15
    max_starting: 5
    max_prealloc: 2
    tags:
    - copr_builder
    - arch_x86_64
    - arch_x86_64_native
    cmd_new: "/var/lib/resallocserver/resalloc_provision/vm-aws-new --arch=x86_64"
    cmd_delete: "/var/lib/resallocserver/resalloc_provision/vm-aws-delete"

And several (5+) tag-matching tickets are taken, only two builders are being started
at the same time.

@praiskup praiskup added the enhancement RFE, feature label May 7, 2020
@praiskup
Copy link
Owner Author

praiskup commented May 7, 2020

Well, work-around is to have max_prealloc >= max_starting which is going
to be our case anyways. So I'm marking this as an enhancement.

The challenge here is that multiple pools could match the taken ticket tags,
and we shouldn't spin up resources unnecessarily in all the pools... Perhaps
this is equivalent or similar to #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement RFE, feature
Projects
None yet
Development

No branches or pull requests

1 participant