Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title: Modification in the services section and some text modification. #32

Open
infilev opened this issue Feb 1, 2023 · 13 comments
Open
Assignees
Labels
Assigned Label is given when a certain issue is assigned easy Points will be: 10. 1 day will be allotted. iwoc This issue/pull request will be considered for IWOC 2k23.

Comments

@infilev
Copy link

infilev commented Feb 1, 2023

Are you a KWOC participant?

NO, I am an IWOC participant.

Is your feature request related to a problem? Please describe.

There are no problems with the index page I have just done some modifications and added some logos.

Describe the solution you'd like.

  • We need to add some effect to the service section which has a subsection of the card.

Describe alternatives you've considered.

  • It can be achieved by adding some animations and using some more transition properties of the CSS.

Add any other context or screenshots about the feature request here.

  • I have opened a pull request as I have finished the modifications and I am waiting for the review
@welcome
Copy link

welcome bot commented Feb 1, 2023

Hello there! 👋🏻 Welcome to the Ezy-Parking! 🚀⚡️
Thank you and congrats 🎉 for opening your very first issue in this project. Please adhere to our Code of Conduct. 👍🏻 You may submit a PR if you like, make sure to follow our Pull Request Template.
Feel free to get in touch with me through social media handles. Hope to see you there!😄

@infilev
Copy link
Author

infilev commented Feb 1, 2023

@prathimacode-hub I have completed all the modifications and opened a PR for the changes.
Although I have opened a PR, assign this issue to me.
Thank you.

@prathimacode-hub
Copy link
Owner

Hello @infilev, we have separate issue for logo. Can you brief it better about what the issue is about? The issue title should depict what's the exact issue you're looking to work upon clearly. You can either modify the existing created issue or create a new issue with the changes. Also mention you're an IWOC participant

@infilev infilev changed the title Title: Modification in the index page and services section. Title: Modification in the services section and some text modification. Feb 3, 2023
@infilev
Copy link
Author

infilev commented Feb 3, 2023

@prathimacode-hub I have added some features to the services section and added the logo which was commented out (issue number #2 ) and I have opened a PR, in which I have explained all the changes with the screenshots.

@prathimacode-hub
Copy link
Owner

Never create PR's without getting an issue assigned. As it's unsure, if the issue has its necessity or not. Have you done the changes in your PR too? @infilev

@prathimacode-hub
Copy link
Owner

What are the features you added? @infilev

@infilev
Copy link
Author

infilev commented Feb 3, 2023

@prathimacode-hub Thank you for telling me about the issue assignment procedure.
I have added a box shadow and a hover effect on the cards in the service section.
Also, I have removed the underline from the text (awesome feature), as it was inappropriate and lastly I changed my issue title and PR title.

@prathimacode-hub
Copy link
Owner

Ok cool. issue assigned to @infilev

@prathimacode-hub prathimacode-hub added Assigned Label is given when a certain issue is assigned iwoc This issue/pull request will be considered for IWOC 2k23. easy Points will be: 10. 1 day will be allotted. labels Feb 4, 2023
@infilev
Copy link
Author

infilev commented Feb 4, 2023

Thank you for assigning also I have completed my work on the issue kindly check out the PR.

@Ayush001612
Copy link

hey @prathimacode-hub please assign this issue to me under iwoc '23

@infilev
Copy link
Author

infilev commented Feb 5, 2023

@Ayush001612 Hello I have already been assigned the issue and have opened a PR for this issue.
Please refer to CODE_OF_CONDUCT and CONTRIBUTING guidelines before opening an issue.

@Akanksha038
Copy link

I would like to contribute to this project. If you think that would be helpful kindly assign this issue to me. Thank You!

@infilev
Copy link
Author

infilev commented Feb 11, 2023

@Akanksha038 Hello, Akanksha this issue has been already assigned to me and I have opened pull request for this issue. Please refer to CODE_OF_CONDUCT and CONTRIBUTING guidelines before opening/contributing to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned Label is given when a certain issue is assigned easy Points will be: 10. 1 day will be allotted. iwoc This issue/pull request will be considered for IWOC 2k23.
Projects
None yet
Development

No branches or pull requests

4 participants