Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All K8s Client calls use context.TODO() as the Context #266

Open
pbelgundi opened this issue Sep 19, 2019 · 0 comments
Open

All K8s Client calls use context.TODO() as the Context #266

pbelgundi opened this issue Sep 19, 2019 · 0 comments
Labels
kind/enhancement Enhancement of an existing feature kind/techdebt Technical debt priority/P2 Slight inconvenience or annoyance to applications, system continues to function

Comments

@pbelgundi
Copy link
Contributor

Description

All operator code uses "context.TODO()" in every k8s client API call.
While it does seem to work, it could be suboptimal and not the right way to invoke the client. Need to spend some time understanding this, its impact and alternatives.
@pbelgundi pbelgundi mentioned this issue Sep 19, 2019
Merged
@pbelgundi pbelgundi added kind/techdebt Technical debt kind/enhancement Enhancement of an existing feature Pravega 0.9 Fix needed by Pravega 0.9 priority/P2 Slight inconvenience or annoyance to applications, system continues to function and removed Pravega 0.9 Fix needed by Pravega 0.9 labels May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Enhancement of an existing feature kind/techdebt Technical debt priority/P2 Slight inconvenience or annoyance to applications, system continues to function
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbelgundi