Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing NodeSelector or Affinity support in the Pravega-Operator helm chart #640

Open
jensjohansen opened this issue Oct 26, 2022 · 0 comments

Comments

@jensjohansen
Copy link

jensjohansen commented Oct 26, 2022

Description

Our k8s cluster has both ARM and AMD X86 processors, so we need either affinity: {} or nodeSelector:{} to work in the helm chart for Pravega Operator.

Importance

Blocker

Location

templates/operator.yaml needs to include the same affinity support that the Pravega/Zookeeper-operator has.

Suggestions for an improvement

Add the following code at about line 21 in templates/operator.yaml

      {{- if .Values.nodeSelector }}
      nodeSelector:
{{ toYaml .Values.nodeSelector | indent 8 }}
      {{- end }}
      {{- if .Values.affinity }}
      affinity:
{{ toYaml .Values.affinity | indent 8 }}
      {{- end }}
      {{- if .Values.tolerations }}
      tolerations:
{{ toYaml .Values.tolerations | indent 8 }}
      {{- end }}

And add the empty place holders around line 18 in values.yaml:

# Scheduling constraints
nodeSelector: {}
affinity: {}
tolerations: []
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant