Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction confirmations are automatically canceled for plans with a lot of actions #130

Closed
Valentine1898 opened this issue Jul 26, 2024 · 6 comments
Labels
bug Something isn't working

Comments

@Valentine1898
Copy link
Contributor

Valentine1898 commented Jul 26, 2024

Describe the bug
Transactions are automatically canceled when trying to create a dutch auction spread over 48 auctions
In some cases this is not reproduced, but more often it is reproduced

To Reproduce
Steps to reproduce the behavior:

  1. Go to Swap
  2. Create dutch auction for 24 or 48 hours
  3. You'll get a approval dialog and transaction cancellation after a couple of seconds

Expected behavior
Prax should be able to create transactions with any number of actions

Screenshots

Screen.Recording.2024-07-26.at.16.53.23.mov
@Valentine1898 Valentine1898 added the bug Something isn't working label Jul 26, 2024
@grod220 grod220 added the priority Important to work on next label Jul 26, 2024
@grod220
Copy link
Contributor

grod220 commented Jul 26, 2024

I can't seem to reproduce this. Do you see any errors in the console for minifront or prax?

@Valentine1898
Copy link
Contributor Author

Valentine1898 commented Jul 26, 2024

I can't seem to reproduce this. Do you see any errors in the console for minifront or prax?

Yes, I'm getting these errors in prax

image

Edited: but I get the same errors if I manually cancel the transaction, so I don't think these are useful errors

@TalDerei
Copy link
Contributor

cc @jessepinho

@Valentine1898
Copy link
Contributor Author

@grod220
I've concluded that the issue here
https://github.com/prax-wallet/web/blob/8141aa42264e9873bbb6f2c625bf12145bc10da6/apps/extension/src/popup.ts#L23
Increasing the timeout solves the issue, but we probably want to have a more flexible solution

@grod220
Copy link
Contributor

grod220 commented Aug 6, 2024

Good find. This relates to this issue: penumbra-zone/web#285. We should have a think about good designs for this.

@grod220
Copy link
Contributor

grod220 commented Aug 28, 2024

Fixed by #174

@grod220 grod220 closed this as completed Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants