-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clearing cache & block sync state #207
Comments
duplicate of penumbra-zone/web#1496. previous offline discussions suggest the fix may be more involved, but I will investigate. |
chrome.runtime.reload() restarts the extension by terminating and reloading the background service worker and injected content scripts. Immediately after reloading the webpage, it causes a redirect to the "Connect to Penumbra" page (see example in penumbra-zone/web#1496). As L pointed out, restarting the background worker breaks the injected content scripts, and the constrained single-threaded service worker blocks the listeners responsible for initializing the content scripts. Wouldn't refactoring the service worker lifecycle automatically resolve this issue as a side-effect? The only additional modification would be to the promise in the message listener by updating it with: I think if we want to tackle this in isolation, we’d need to ensure that the wallet connection status, which is handled by a content script, persists during |
Yes, I think that |
even with that line, it will immediately display a "data objects could not be cloned causing transactions to fail" error. Then, if you try refreshing the screen, it redirects to the "Connect to Penumbra" page – see video example in penumbra-zone/web#1496. |
…al storage after cache clearing" This reverts commit d085ff3.
…ge after cache clearing (#217) * fix(extension): #207: fix resetting the fullSyncHeight in local storage after cache clearing * fix(extension): #207: change zeros to undefined * Revert "fix(extension): #207: change zeros to undefined" This reverts commit 29ff515. * Revert "fix(extension): #207: fix resetting the fullSyncHeight in local storage after cache clearing" This reverts commit d085ff3. * fix(extension): #207: use `allSettled` to remove the fullSyncHeight from the storage
When clearing cache, the last block synced status does not clear until a new block is synced. This can cause feelings of unresponsiveness. In case of mainnet, genesis state sync can take some time so it accentuate this feeling. Example:
compressed.mov
Likely need to explicitly reset the chrome.storage.local value for lastBlockSynced when issuing a cache clear action.
The text was updated successfully, but these errors were encountered: