Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding will suddenly abort if you try to continue with custom rpc #69

Closed
Tracked by #68
Valentine1898 opened this issue Jun 28, 2024 · 2 comments · Fixed by #70
Closed
Tracked by #68

Onboarding will suddenly abort if you try to continue with custom rpc #69

Valentine1898 opened this issue Jun 28, 2024 · 2 comments · Fixed by #70
Assignees
Labels
bug Something isn't working priority Important to work on next

Comments

@Valentine1898
Copy link
Contributor

If you try to use custom RPC during the onboarding phase, a chain-id change warning window will be shown (which probably shouldn't have been shown).
Most likely, this also sends a СlearCache message to the service worker, but the service worker is not initialized yet and this causes a crash
image

@Valentine1898 Valentine1898 added the bug Something isn't working label Jun 28, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Jun 28, 2024
@grod220 grod220 added the priority Important to work on next label Jun 28, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 📝 Todo in Labs web Jun 28, 2024
@Valentine1898 Valentine1898 self-assigned this Jun 28, 2024
@grod220
Copy link
Contributor

grod220 commented Jun 28, 2024

Good find. I think this slipped through as we've been typically entering in custom RPCs that serve the same chain id.

However, there is an issue when there will be zero rpcs in the list. With fixEmptyGrpcEndpointAfterOnboarding(), there is a hardcoded testnet rpc there that prefills the input. We should delete this. But it also is subject to the bug you found (trying to go from testnet -> another chain... popup err).

@grod220 grod220 mentioned this issue Jun 28, 2024
17 tasks
@Valentine1898
Copy link
Contributor Author

Aww, it's not that simple with fixEmptyGrpcEndpointAfterOnboarding. If we want to remove this logic, we need to consider that the user can interrupt onboarding at any time and come back to it later. In this case, if the user has not yet selected RPC, then we should not consider that his onboarding is complete

@Valentine1898 Valentine1898 linked a pull request Jun 28, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 📝 Todo to ✅ Done in Labs web Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Important to work on next
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants