Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: _input.css borks some plugin's settings pages #160

Open
mihawk90 opened this issue Sep 17, 2024 · 0 comments
Open

Bug: _input.css borks some plugin's settings pages #160

mihawk90 opened this issue Sep 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mihawk90
Copy link
Contributor

mihawk90 commented Sep 17, 2024

Describe the bug
While going through some of my plugin settings I noticed that on one of them, one of the settings lists was messed up. I first assumed it was an issue with the plugin, however after digging a bit this is actually an issue with JellySkin.

To Reproduce

  1. Install the ListenBrainz plugin by Lyarenei (it's the plugin I noticed it on, I don't know what other plugins are affected)
  2. Open the settings page of the Listenbrainz plugin
  3. Scroll to the bottom section named "Allowed libraries for listen submission"
  4. If you have multiple libraries, the checkboxes and labels will be stacked on top of eachother

Expected behavior
The lists should display correctly

Screenshots
image

The settings on the top are also messed up but those are not that big of a deal, the main issue is the "list" at the bottom.

Desktop (please complete the following information):

  • OS: Fedora 40
  • Browser: Vivaldi
  • Version: 6.10 (Snapshot version)

Additional context
The problem is in these lines:

.inputLabel {
top: -1.2em;
font-size: 0.95em;
position: absolute;

Since the position is absolute all elements are adjusted to their next relative positioned parent, in this case the .inputContainer.
I'm not exactly sure what the purpose of these lines was since there's no comments, so I don't know where in the user-facing front-end this applies.
Removing the absolute position fixes all of these lists.

edit:
Actually, removing it only fixes the labels, but not the checkboxes. They are handled separately.

@mihawk90 mihawk90 added the bug Something isn't working label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant