diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index cb734d53cc..3ce89abe1f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ on: description: 'Branch or tag ref to check out' type: string required: false - default: 'main' + default: '' artifact_name: description: 'Name of the artifact to upload' type: string diff --git a/.github/workflows/run-bench.yml b/.github/workflows/run-bench.yml index 97a0ddbf42..248d974493 100644 --- a/.github/workflows/run-bench.yml +++ b/.github/workflows/run-bench.yml @@ -53,6 +53,9 @@ jobs: with: name: results path: benches/results/${{ inputs.benchmark }}.json + - name: Anaylze logs if present + working-directory: benches + run: '[ -d logs ] && npm run analyze || echo "No logs to analyze"' - name: Tar logs if present working-directory: benches run: '[ -d logs ] && tar -zcvf ${{ inputs.benchmark}}_logs.tgz logs || echo "No logs found"' diff --git a/.github/workflows/single-bench.yml b/.github/workflows/single-bench.yml index 667c8b0eef..e59c4e1f44 100644 --- a/.github/workflows/single-bench.yml +++ b/.github/workflows/single-bench.yml @@ -26,11 +26,15 @@ on: type: boolean default: true required: false - timeout: - description: 'How many minutes to give the benchmark to run before timing out and failing' - type: number - default: 20 - required: false + # A bug in GitHub actions prevents us from passing numbers (as either + # number or string type) to called workflows. So disabling this for now. + # See: https://github.com/orgs/community/discussions/67182 + # + # timeout: + # description: 'How many minutes to give the benchmark to run before timing out and failing' + # type: number + # default: 20 + # required: false jobs: build_local: @@ -57,17 +61,17 @@ jobs: with: name: npm-package - run: mv preact.tgz preact-local.tgz + - name: Upload locally built preact package + uses: actions/upload-artifact@v3 + with: + name: bench-environment + path: preact-local.tgz - name: Clear working directory run: | ls -al rm -rf * echo "====================" ls -al - - name: Upload locally built preact package - uses: actions/upload-artifact@v3 - with: - name: bench-environment - path: preact-local.tgz - name: Download base package uses: actions/download-artifact@v3 with: @@ -80,10 +84,10 @@ jobs: path: preact-main.tgz benchmark: - name: Bench ${{ inputs.benchmark}} + name: Bench ${{ inputs.benchmark }} uses: ./.github/workflows/run-bench.yml needs: prepare with: - benchmark: ${{ inputs.benchmark}} - timeout: ${{ inputs.timeout }} + benchmark: ${{ inputs.benchmark }} trace: ${{ inputs.trace }} + # timeout: ${{ inputs.timeout }}