Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(major) - Tracking PR for v11 #4549

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

(major) - Tracking PR for v11 #4549

wants to merge 33 commits into from

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 10, 2024

We will do this as a means to remove IE11, cleanup our imports exports and drive support for #4613 in 11 rather than X.

Closes #4613
Closes #4406
Closes #3084
Closes #4442
Closes #4461
Closes #4406
Closes #3335 as won't do
Closes #2004 as won't do
Closes #2331 as won't do

Breaking changes

Features

Fixes

Questions

Rejected

Copy link

github-actions bot commented Nov 10, 2024

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-7.33ms - +8.55ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.09ms - +0.19ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.43ms - +0.51ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.19ms - +0.03ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -2% - +0% (-1.62ms - +0.10ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - +6% (-0.01ms - +0.12ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -3% - +3% (-0.96ms - +1.02ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -5% - +2% (-1.58ms - +0.68ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 +0% - +0% (+0.02ms - +0.04ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -2% - +1% (-0.04ms - +0.02ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -3% - +5% (-0.27ms - +0.45ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +1% (-0.03ms - +0.03ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -1% - +1% (-0.02ms - +0.02ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -0% - -0% (-0.00ms - -0.00ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +2% (-0.02ms - +0.03ms)
    preact-local vs preact-main
  • update10th1k: faster ✔ 0% - 2% (0.01ms - 0.07ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local935.10ms - 948.59ms-unsure 🔍
-1% - +1%
-7.33ms - +8.55ms
preact-main937.04ms - 945.44msunsure 🔍
-1% - +1%
-8.55ms - +7.33ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.20ms - 19.22ms-unsure 🔍
+0% - +0%
+0.02ms - +0.04ms
preact-main19.18ms - 19.18msunsure 🔍
-0% - -0%
-0.04ms - -0.02ms
-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.77ms-unsure 🔍
-1% - +1%
-0.09ms - +0.19ms
preact-main16.56ms - 16.62msunsure 🔍
-1% - +1%
-0.19ms - +0.09ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.53ms - 1.57ms-unsure 🔍
-2% - +1%
-0.04ms - +0.02ms
preact-main1.54ms - 1.58msunsure 🔍
-1% - +2%
-0.02ms - +0.04ms
-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local74.38ms - 75.00ms-unsure 🔍
-1% - +1%
-0.43ms - +0.51ms
preact-main74.30ms - 75.00msunsure 🔍
-1% - +1%
-0.51ms - +0.43ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local9.57ms - 10.10ms-unsure 🔍
-3% - +5%
-0.27ms - +0.45ms
preact-main9.51ms - 9.98msunsure 🔍
-5% - +3%
-0.45ms - +0.27ms
-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.43ms - 16.63ms-unsure 🔍
-1% - +0%
-0.19ms - +0.03ms
preact-main16.55ms - 16.67msunsure 🔍
-0% - +1%
-0.03ms - +0.19ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.77ms - 3.80ms-unsure 🔍
-1% - +1%
-0.03ms - +0.03ms
preact-main3.77ms - 3.80msunsure 🔍
-1% - +1%
-0.03ms - +0.03ms
-
replace1k
  • Browser: chrome-headless
  • Sample size: 100
  • Built by: CI #4472
  • Commit: d1aa1d3

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.05ms - 67.11ms-unsure 🔍
-2% - +0%
-1.62ms - +0.10ms
preact-main66.66ms - 68.02msunsure 🔍
-0% - +2%
-0.10ms - +1.62ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.97ms - 3.00ms-unsure 🔍
-1% - +1%
-0.02ms - +0.02ms
preact-main2.97ms - 2.99msunsure 🔍
-1% - +1%
-0.02ms - +0.02ms
-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local29.74ms - 30.54ms-unsure 🔍
-2% - +1%
-0.53ms - +0.43ms
preact-main29.92ms - 30.45msunsure 🔍
-1% - +2%
-0.43ms - +0.53ms
-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local33.37ms - 34.51ms-unsure 🔍
-3% - +1%
-1.00ms - +0.43ms
preact-main33.80ms - 34.65msunsure 🔍
-1% - +3%
-0.43ms - +1.00ms
-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local25.32ms - 25.66ms-faster ✔
1% - 3%
0.15ms - 0.68ms
preact-main25.70ms - 26.11msslower ❌
1% - 3%
0.15ms - 0.68ms
-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local23.77ms - 24.84ms-faster ✔
4% - 9%
0.92ms - 2.40ms
preact-main25.46ms - 26.47msslower ❌
4% - 10%
0.92ms - 2.40ms
-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local23.80ms - 25.05ms-faster ✔
7% - 12%
1.90ms - 3.39ms
preact-main26.65ms - 27.49msslower ❌
8% - 14%
1.90ms - 3.39ms
-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local19.95ms - 20.34ms-faster ✔
1% - 3%
0.14ms - 0.70ms
preact-main20.37ms - 20.77msslower ❌
1% - 4%
0.14ms - 0.70ms
-
text-update
  • Browser: chrome-headless
  • Sample size: 220
  • Built by: CI #4472
  • Commit: d1aa1d3

duration

VersionAvg timevs preact-localvs preact-main
preact-local2.10ms - 2.19ms-unsure 🔍
-0% - +6%
-0.01ms - +0.12ms
preact-main2.05ms - 2.14msunsure 🔍
-5% - +0%
-0.12ms - +0.01ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.12ms - 1.12ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-main1.12ms - 1.12msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local33.16ms - 35.12ms-unsure 🔍
-3% - +3%
-0.96ms - +1.02ms
preact-main34.00ms - 34.22msunsure 🔍
-3% - +3%
-1.02ms - +0.96ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.23ms - 1.27ms-unsure 🔍
-1% - +2%
-0.02ms - +0.03ms
preact-main1.23ms - 1.26msunsure 🔍
-2% - +1%
-0.03ms - +0.02ms
-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.41ms - 33.81ms-unsure 🔍
-5% - +2%
-1.58ms - +0.68ms
preact-main32.68ms - 34.45msunsure 🔍
-2% - +5%
-0.68ms - +1.58ms
-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.93ms - 2.97ms-faster ✔
0% - 2%
0.01ms - 0.07ms
preact-main2.97ms - 3.02msslower ❌
0% - 3%
0.01ms - 0.07ms
-

tachometer-reporter-action v2 for CI

Copy link

github-actions bot commented Nov 10, 2024

Size Change: -32 kB (-40.83%) 🎉

Total Size: 46.4 kB

Filename Size Change
compat/dist/compat.js 3.69 kB -427 B (-10.36%) 👏
compat/dist/compat.mjs 3.61 kB -437 B (-10.8%) 👏
compat/dist/compat.module.js 0 B -4.05 kB (removed) 🏆
compat/dist/compat.umd.js 3.75 kB -436 B (-10.41%) 👏
debug/dist/debug.js 3.87 kB +35 B (+0.91%)
debug/dist/debug.mjs 3.87 kB +35 B (+0.91%)
debug/dist/debug.module.js 0 B -3.83 kB (removed) 🏆
debug/dist/debug.umd.js 3.95 kB +40 B (+1.02%)
devtools/dist/devtools.mjs 271 B -3 B (-1.09%)
devtools/dist/devtools.module.js 0 B -274 B (removed) 🏆
dist/preact.js 4.59 kB -129 B (-2.73%)
dist/preact.min.js 0 B -4.73 kB (removed) 🏆
dist/preact.min.module.js 0 B -4.75 kB (removed) 🏆
dist/preact.min.umd.js 0 B -4.75 kB (removed) 🏆
dist/preact.mjs 4.61 kB -123 B (-2.6%)
dist/preact.module.js 0 B -4.74 kB (removed) 🏆
dist/preact.umd.js 4.66 kB -99 B (-2.08%)
hooks/dist/hooks.js 1.55 kB +13 B (+0.85%)
hooks/dist/hooks.mjs 1.58 kB +8 B (+0.51%)
hooks/dist/hooks.module.js 0 B -1.57 kB (removed) 🏆
hooks/dist/hooks.umd.js 1.62 kB +11 B (+0.68%)
jsx-runtime/dist/jsxRuntime.js 861 B -117 B (-11.96%) 👏
jsx-runtime/dist/jsxRuntime.mjs 830 B -122 B (-12.82%) 👏
jsx-runtime/dist/jsxRuntime.module.js 0 B -952 B (removed) 🏆
jsx-runtime/dist/jsxRuntime.umd.js 934 B -118 B (-11.22%) 👏
test-utils/dist/testUtils.mjs 473 B -4 B (-0.84%)
test-utils/dist/testUtils.module.js 0 B -477 B (removed) 🏆
ℹ️ View Unchanged
Filename Size
devtools/dist/devtools.js 260 B
devtools/dist/devtools.umd.js 346 B
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@coveralls
Copy link

coveralls commented Nov 10, 2024

Coverage Status

coverage: 99.454% (-0.2%) from 99.609%
when pulling d1aa1d3 on v11-2
into 2a788d6 on main.

@JoviDeCroock JoviDeCroock force-pushed the v11-2 branch 4 times, most recently from af99557 to 067be2b Compare November 10, 2024 13:13
@rschristian
Copy link
Member

#4406 would be another easy thing to fit in, swapping out our (pretty much unused & problematic) package.json##browser condition for package.json##module

@JoviDeCroock JoviDeCroock force-pushed the v11-2 branch 2 times, most recently from a12176d to 14ea8f6 Compare November 23, 2024 08:23
@JoviDeCroock JoviDeCroock force-pushed the v11-2 branch 2 times, most recently from 5caed5c to 39339b2 Compare December 22, 2024 09:19
@JoviDeCroock JoviDeCroock force-pushed the v11-2 branch 2 times, most recently from d328910 to 41622b2 Compare February 11, 2025 08:40
@JoviDeCroock JoviDeCroock marked this pull request as ready for review February 11, 2025 09:45
@JoviDeCroock JoviDeCroock changed the title V11 2 (major) - Tracking PR for v11 Feb 11, 2025
src/util.js Show resolved Hide resolved
src/diff/index.js Outdated Show resolved Hide resolved
src/diff/index.js Outdated Show resolved Hide resolved
src/diff/index.js Outdated Show resolved Hide resolved
src/render.js Outdated Show resolved Hide resolved
JoviDeCroock and others added 7 commits February 19, 2025 20:39
* Revert assign and avoid repeating indexed access

* Check parentNode instead

* Use flag

* Remove type

* Remove todo file
* Forward ref by default

* Optimizations
JoviDeCroock and others added 19 commits February 19, 2025 20:40
* Move `defaultProps` into `preact/compat`

This will be handled in `options.vnode` for function/class components.
This hook gets called for every invocation of `jsx`/`createElement` and
`cloneElement`.

* Try it

* refactor: This is horrific but seems to work? (#4662)

---------

Co-authored-by: Ryan Christian <[email protected]>
* Remove unused imports

* Comment denoted hydration

* Make it work

* Golfies
* Remove unused imports

* refactor: Switch to Object.is for hook args

* refactor: Copy to `useReducer` & store `Object` accessor

* test: Add tests for `useEffect` & `useState` w/ `NaN`

Co-authored-by: jayrobin <[email protected]>

---------

Co-authored-by: jdecroock <[email protected]>
Co-authored-by: jayrobin <[email protected]>
This reverts commit 6b8bfa2.
* refactor: Switch to `package.json#exports.module`, drop `.min` builds, &  use `.mjs` exclusively

* chore: Remove leftover CJS shell

* test: Fix export for karma

* fix: coverage not generated in minify tests

---------

Co-authored-by: Marvin Hagemeister <[email protected]>
* Remove automatic px suffix

* Remove from jsx-runtime
@JoviDeCroock JoviDeCroock force-pushed the v11-2 branch 2 times, most recently from 49c0171 to d1aa1d3 Compare February 19, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants