-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(major) - Tracking PR for v11 #4549
Open
JoviDeCroock
wants to merge
33
commits into
main
Choose a base branch
from
v11-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
Size Change: -32 kB (-40.83%) 🎉 Total Size: 46.4 kB
ℹ️ View Unchanged
|
af99557
to
067be2b
Compare
#4406 would be another easy thing to fit in, swapping out our (pretty much unused & problematic) |
a12176d
to
14ea8f6
Compare
5caed5c
to
39339b2
Compare
d328910
to
41622b2
Compare
developit
reviewed
Feb 11, 2025
JoviDeCroock
commented
Feb 12, 2025
8811459
to
ef1f51f
Compare
* Revert assign and avoid repeating indexed access * Check parentNode instead * Use flag * Remove type * Remove todo file
* Forward ref by default * Optimizations
* Move `defaultProps` into `preact/compat` This will be handled in `options.vnode` for function/class components. This hook gets called for every invocation of `jsx`/`createElement` and `cloneElement`. * Try it * refactor: This is horrific but seems to work? (#4662) --------- Co-authored-by: Ryan Christian <[email protected]>
* Remove unused imports * Comment denoted hydration * Make it work * Golfies
* Remove unused imports * refactor: Switch to Object.is for hook args * refactor: Copy to `useReducer` & store `Object` accessor * test: Add tests for `useEffect` & `useState` w/ `NaN` Co-authored-by: jayrobin <[email protected]> --------- Co-authored-by: jdecroock <[email protected]> Co-authored-by: jayrobin <[email protected]>
This reverts commit 6b8bfa2.
* refactor: Switch to `package.json#exports.module`, drop `.min` builds, & use `.mjs` exclusively * chore: Remove leftover CJS shell * test: Fix export for karma * fix: coverage not generated in minify tests --------- Co-authored-by: Marvin Hagemeister <[email protected]>
* Remove automatic px suffix * Remove from jsx-runtime
49c0171
to
d1aa1d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will do this as a means to remove IE11, cleanup our imports exports and drive support for #4613 in 11 rather than X.
Closes #4613
Closes #4406
Closes #3084
Closes #4442
Closes #4461
Closes #4406
Closes #3335 as won't do
Closes #2004 as won't do
Closes #2331 as won't do
Breaking changes
Component.base
SuspenseList
module.js
export refactor: Breaking changes to outputs & pkg.json #4652defaultProps
frompreact
and intopreact/compat
MovedefaultProps
intopreact/compat
#4657If you need this you can always polyfill it by doing
options.vnode = (vnode) => { if (vnode.props.ref) { vnode.ref = vnode.props.ref; delete vnode.props.ref; } }
style
px suffixing to compat, note that this affects core and the jsx-template transform (Remove automatic px suffix #4665)Features
Fixes
_listeners
(fix:_listeners
mangle to reduce collisions #4463)Object.is
for hook equality (refactor: Switch to Object.is for hook args #4663)Questions
_depth
,_original
or_flags
to the backing component instance (perf?)document
Add an option to inject thedocument
for arender()
#4500 and WrongDocumentError due todocument.createElement
#2545_force
on all components part of a bubbling phase useEffect didn't run in some rare case (lazy + memo) #4631 and the child component of ErrorBoundary, wrapped by memo function failed to recover from the last error #3449Rejected