Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event proxy exception #3473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

michael-graves-dojo
Copy link

Prevent event proxy functions from throwing exceptions in the rare case _listeners is not set

Fixes issue #3218

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -3% - +3% (-3.44ms - +3.46ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -5% - +4% (-2.45ms - +2.21ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -1% - +1% (-13.19ms - +8.64ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -1% - +4% (-0.25ms - +1.21ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -2% - +6% (-3.59ms - +11.77ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -5% - +3% (-1.01ms - +0.61ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 -3% - +5% (-0.07ms - +0.14ms)
    preact-local vs preact-master

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +1% (-0.01ms - +0.03ms)
    preact-local vs preact-master
  • 03_update10th1k_x16: unsure 🔍 -1% - +0% (-0.03ms - +0.02ms)
    preact-local vs preact-master
  • 07_create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-master
  • filter_list: unsure 🔍 -2% - +1% (-0.04ms - +0.01ms)
    preact-local vs preact-master
  • hydrate1k: unsure 🔍 -0% - +1% (-0.01ms - +0.05ms)
    preact-local vs preact-master
  • many_updates: unsure 🔍 -0% - +0% (-0.02ms - +0.01ms)
    preact-local vs preact-master
  • text_update: unsure 🔍 +0% - +0% (+0.00ms - +0.00ms)
    preact-local vs preact-master

Results

02_replace1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master125.34ms - 130.35ms-unsure 🔍
-3% - +3%
-3.46ms - +3.44ms
preact-local125.49ms - 130.22msunsure 🔍
-3% - +3%
-3.44ms - +3.46ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.55ms - 3.58ms-unsure 🔍
-1% - +0%
-0.03ms - +0.01ms
preact-local3.56ms - 3.60msunsure 🔍
-0% - +1%
-0.01ms - +0.03ms
-

run-warmup-0

VersionAvg timevs preact-mastervs preact-local
preact-master49.23ms - 51.01ms-unsure 🔍
-3% - +2%
-1.40ms - +1.05ms
preact-local49.45ms - 51.14msunsure 🔍
-2% - +3%
-1.05ms - +1.40ms
-

run-warmup-1

VersionAvg timevs preact-mastervs preact-local
preact-master71.30ms - 75.07ms-unsure 🔍
-5% - +1%
-3.57ms - +1.01ms
preact-local73.16ms - 75.76msunsure 🔍
-1% - +5%
-1.01ms - +3.57ms
-

run-warmup-2

VersionAvg timevs preact-mastervs preact-local
preact-master56.98ms - 63.93ms-unsure 🔍
-10% - +6%
-6.22ms - +3.61ms
preact-local58.27ms - 65.24msunsure 🔍
-6% - +10%
-3.61ms - +6.22ms
-

run-warmup-3

VersionAvg timevs preact-mastervs preact-local
preact-master51.09ms - 57.63ms-unsure 🔍
-8% - +10%
-4.10ms - +5.31ms
preact-local50.37ms - 57.14msunsure 🔍
-10% - +7%
-5.31ms - +4.10ms
-

run-warmup-4

VersionAvg timevs preact-mastervs preact-local
preact-master68.55ms - 71.88ms-unsure 🔍
-3% - +5%
-1.78ms - +3.29ms
preact-local67.55ms - 71.37msunsure 🔍
-5% - +3%
-3.29ms - +1.78ms
-

run-final

VersionAvg timevs preact-mastervs preact-local
preact-master43.03ms - 46.26ms-unsure 🔍
-5% - +5%
-2.04ms - +2.43ms
preact-local42.90ms - 46.00msunsure 🔍
-5% - +5%
-2.43ms - +2.04ms
-
03_update10th1k_x16

duration

VersionAvg timevs preact-mastervs preact-local
preact-master52.13ms - 55.59ms-unsure 🔍
-4% - +5%
-2.21ms - +2.45ms
preact-local52.19ms - 55.30msunsure 🔍
-5% - +4%
-2.45ms - +2.21ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master3.45ms - 3.48ms-unsure 🔍
-0% - +1%
-0.02ms - +0.03ms
preact-local3.44ms - 3.47msunsure 🔍
-1% - +0%
-0.03ms - +0.02ms
-
07_create10k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master1454.96ms - 1470.66ms-unsure 🔍
-1% - +1%
-8.64ms - +13.19ms
preact-local1452.95ms - 1468.12msunsure 🔍
-1% - +1%
-13.19ms - +8.64ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master25.36ms - 25.36ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-local25.36ms - 25.36msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms
-
filter_list

duration

VersionAvg timevs preact-mastervs preact-local
preact-master28.03ms - 29.05ms-unsure 🔍
-4% - +1%
-1.21ms - +0.25ms
preact-local28.50ms - 29.54msunsure 🔍
-1% - +4%
-0.25ms - +1.21ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master1.62ms - 1.66ms-unsure 🔍
-1% - +2%
-0.01ms - +0.04ms
preact-local1.61ms - 1.64msunsure 🔍
-2% - +1%
-0.04ms - +0.01ms
-
hydrate1k

duration

VersionAvg timevs preact-mastervs preact-local
preact-master194.19ms - 206.23ms-unsure 🔍
-6% - +2%
-11.77ms - +3.59ms
preact-local199.53ms - 209.07msunsure 🔍
-2% - +6%
-3.59ms - +11.77ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master6.21ms - 6.25ms-unsure 🔍
-1% - +0%
-0.05ms - +0.01ms
preact-local6.22ms - 6.27msunsure 🔍
-0% - +1%
-0.01ms - +0.05ms
-
many_updates

duration

VersionAvg timevs preact-mastervs preact-local
preact-master21.71ms - 22.84ms-unsure 🔍
-3% - +5%
-0.61ms - +1.01ms
preact-local21.49ms - 22.66msunsure 🔍
-5% - +3%
-1.01ms - +0.61ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master4.65ms - 4.67ms-unsure 🔍
-0% - +0%
-0.01ms - +0.02ms
preact-local4.65ms - 4.66msunsure 🔍
-0% - +0%
-0.02ms - +0.01ms
-
text_update

duration

VersionAvg timevs preact-mastervs preact-local
preact-master2.82ms - 2.97ms-unsure 🔍
-5% - +2%
-0.14ms - +0.07ms
preact-local2.85ms - 3.01msunsure 🔍
-3% - +5%
-0.07ms - +0.14ms
-

usedJSHeapSize

VersionAvg timevs preact-mastervs preact-local
preact-master0.82ms - 0.82ms-unsure 🔍
-0% - -0%
-0.00ms - -0.00ms
preact-local0.82ms - 0.82msunsure 🔍
+0% - +0%
+0.00ms - +0.00ms
-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.625% when pulling a5bb7de on michael-graves-dojo:master into d4a3013 on preactjs:master.

@michael-graves-dojo michael-graves-dojo changed the title [draft] Fix event proxy exception Fix event proxy exception Mar 9, 2022
@rasapetter
Copy link

Any updates here? The fix seems sane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants