Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a configuration file to configure the adapter #25

Open
BenjaminRodenberg opened this issue Apr 29, 2022 · 0 comments
Open

Use a configuration file to configure the adapter #25

BenjaminRodenberg opened this issue Apr 29, 2022 · 0 comments
Assignees
Milestone

Comments

@BenjaminRodenberg
Copy link
Member

The adapter requires some names in the precice-config.xml to agree with hard-coded names in this adapter. The user may customize these names, but this requires recompiling the adapter, so this is not user-friendly.

A common solution for other preCICE adapter is to provide a configuration file to the adapter at runtime. From the preCICE perspective we decided at some point in time to try to stick to what is a common file format in the "world" of the adapter solver to make this easy to configure for users. This usually also avoids additional dependencies for building the adapter. (compare OpenFOAM adapter using an OpenFOAM dictionary, FEniCS adapter using a json)

So the main question here is which kind of formats would feel natural for a Fluent user?

Some options that we (@mtree22, @IshaanDesai, @MakisH, @fsimonis) already discussed:

  • scheme files
  • xml
  • yaml
  • more suggestions are welcome.
@BenjaminRodenberg BenjaminRodenberg added this to the v0.1.0 milestone Apr 29, 2022
@IshaanDesai IshaanDesai self-assigned this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants